Re: [PATCH 6/6] submodule: refactor logic to determine changed submodules

2017-05-01 Thread Brandon Williams
On 04/28, Stefan Beller wrote: > + Heiko, who touched the pushing code end of last year. > > On Fri, Apr 28, 2017 at 4:54 PM, Brandon Williams wrote: > > There are currently two instances (fetch and push) where we want to > > determine if submodules have changed given some

Re: [PATCH 6/6] submodule: refactor logic to determine changed submodules

2017-04-28 Thread Stefan Beller
+ Heiko, who touched the pushing code end of last year. On Fri, Apr 28, 2017 at 4:54 PM, Brandon Williams wrote: > There are currently two instances (fetch and push) where we want to > determine if submodules have changed given some revision specification. > These two

[PATCH 6/6] submodule: refactor logic to determine changed submodules

2017-04-28 Thread Brandon Williams
There are currently two instances (fetch and push) where we want to determine if submodules have changed given some revision specification. These two instances don't use the same logic to generate a list of changed submodules and as a result there is a fair amount of code duplication. This patch