The other hooks use two whitespace for indentation instead of tabs
to signify code in the example/echo output.
Follow the same layout in templates/hooks--pre-rebase.sample
Based on d153a68bebfabc1db5241d02ee75fa5cb4538ab0 in original patch
series from 2013-06-10.
Signed-off-by: Richard Hartmann
Richard Hartmann wrote:
The other hooks use two whitespace for indentation instead of tabs
to signify code in the example/echo output.
Follow the same layout in templates/hooks--pre-rebase.sample
I don't understand the point of this one. Is it just consistency for
the sake of consistency?
The other hooks use two whitespace for indentation instead of tabs
to signify code in the example/echo output.
Follow the same layout in templates/hooks--pre-rebase.sample
Signed-off-by: Richard Hartmann richih.mailingl...@gmail.com
---
templates/hooks--pre-rebase.sample | 10 +-
1
Richard Hartmann richih.mailingl...@gmail.com writes:
The other hooks use two whitespace for indentation instead of tabs
to signify code in the example/echo output.
Follow the same layout in templates/hooks--pre-rebase.sample
Signed-off-by: Richard Hartmann richih.mailingl...@gmail.com
---
On Mon, Jun 10, 2013 at 9:52 PM, Junio C Hamano gits...@pobox.com wrote:
I think offsetting the actual commands to the right is correct, but
if these match and if this is empty should be flushed to left as
this patch shows.
I actually considered this and decided against it as it seemed to be
that, I think it is a good addition.
[PATCH 5/6] templates: Fix ASCII art in pre-rebase hook
Good, but see Peff's comments on the explanation.
[PATCH 6/6] template: Fix comment indentation in pre-rebase hook
After reading the original once again, it is fine as-is without
the change at all, I
it is a good addition.
Will update once I know the complete TODO.
[PATCH 5/6] templates: Fix ASCII art in pre-rebase hook
Good, but see Peff's comments on the explanation.
OK.
[PATCH 6/6] template: Fix comment indentation in pre-rebase hook
After reading the original once again, it is fine
7 matches
Mail list logo