Re: [PATCH 6/7] trace: disable key after write error

2016-08-05 Thread Jeff King
On Thu, Aug 04, 2016 at 05:22:44PM -0400, Jeff King wrote: > On Thu, Aug 04, 2016 at 01:45:11PM -0700, Junio C Hamano wrote: > > > Jeff King writes: > > > > > If we get a write error writing to a trace descriptor, the > > > error isn't likely to go away if we keep writing. Instead, > > > you'll

Re: [PATCH 6/7] trace: disable key after write error

2016-08-04 Thread Jeff King
On Thu, Aug 04, 2016 at 01:45:11PM -0700, Junio C Hamano wrote: > Jeff King writes: > > > If we get a write error writing to a trace descriptor, the > > error isn't likely to go away if we keep writing. Instead, > > you'll just get the same error over and over. E.g., try: > > > > GIT_TRACE_PAC

Re: [PATCH 6/7] trace: disable key after write error

2016-08-04 Thread Junio C Hamano
Jeff King writes: > If we get a write error writing to a trace descriptor, the > error isn't likely to go away if we keep writing. Instead, > you'll just get the same error over and over. E.g., try: > > GIT_TRACE_PACKET=42 git ls-remote >/dev/null > > You don't really need to see: > > warning

[PATCH 6/7] trace: disable key after write error

2016-08-03 Thread Jeff King
If we get a write error writing to a trace descriptor, the error isn't likely to go away if we keep writing. Instead, you'll just get the same error over and over. E.g., try: GIT_TRACE_PACKET=42 git ls-remote >/dev/null You don't really need to see: warning: unable to write trace for GIT_TRA