Re: [PATCH 7/7] diff.c: add --color-moved-ignore-space-delta option

On Tue, 24 Apr 2018 16:23:28 -0700 Stefan Beller wrote: > >> s/missmatch/mismatch/ > >> Also, what is this used for? > > > > The mismatch should be used for (thanks for catching!) > > checking if the remainder of a line is the same, although a boolean > > may be not the

Re: [PATCH 7/7] diff.c: add --color-moved-ignore-space-delta option

Replied to Jonathan only instead of all. My reply is below: On Tue, Apr 24, 2018 at 3:55 PM, Stefan Beller wrote: > On Tue, Apr 24, 2018 at 3:35 PM, Jonathan Tan > wrote: >> On Tue, 24 Apr 2018 14:03:30 -0700 >> Stefan Beller

Re: [PATCH 7/7] diff.c: add --color-moved-ignore-space-delta option

On Tue, 24 Apr 2018 14:03:30 -0700 Stefan Beller wrote: > +--color-moved-[no-]ignore-space-prefix-delta:: > + Ignores whitespace when comparing lines when performing the move > + detection for --color-moved. This ignores uniform differences > + of white space at

[PATCH 7/7] diff.c: add --color-moved-ignore-space-delta option

This marks moved code still as blocks when their indentation level changes uniformly. Signed-off-by: Stefan Beller --- Documentation/diff-options.txt | 4 ++ diff.c | 83 +++--- diff.h | 2 +

Re: [PATCH 7/7] diff.c: add --color-moved-ignore-space-delta option

On Tue, 3 Apr 2018 12:22:32 -0700 Stefan Beller wrote: > On Mon, Apr 2, 2018 at 5:41 PM, Jonathan Tan wrote: > > On Mon, 2 Apr 2018 15:48:54 -0700 > > Stefan Beller wrote: > > > >> +struct ws_delta { > >> + int deltachars;

Re: [PATCH 7/7] diff.c: add --color-moved-ignore-space-delta option

On Mon, Apr 2, 2018 at 5:41 PM, Jonathan Tan wrote: > On Mon, 2 Apr 2018 15:48:54 -0700 > Stefan Beller wrote: > >> +struct ws_delta { >> + int deltachars; >> + char firstchar; >> +}; > > I'll just make some overall design comments. > >

Re: [PATCH 7/7] diff.c: add --color-moved-ignore-space-delta option

On Mon, 2 Apr 2018 15:48:54 -0700 Stefan Beller wrote: > +struct ws_delta { > + int deltachars; > + char firstchar; > +}; I'll just make some overall design comments. Shouldn't this be a string of characters (or a char* and len) and whether it was added or removed?

[PATCH 7/7] diff.c: add --color-moved-ignore-space-delta option

This marks moved code still as blocks when their indentation level changes uniformly. Signed-off-by: Stefan Beller --- diff.c | 93 -- diff.h | 1 + t/t4015-diff-whitespace.sh | 191