Re: [PATCH 7/8] diff.c: compute reverse locally in emit_line_0

2018-08-13 Thread Stefan Beller
On Mon, Aug 13, 2018 at 5:26 AM Johannes Schindelin wrote: > > Hi, > > > On Fri, 10 Aug 2018, Stefan Beller wrote: > > > Signed-off-by: Stefan Beller > > Signed-off-by: Junio C Hamano > > Well, my rationale for having the explicit `reverse` parameter is: this > code is complex enough,

Re: [PATCH 7/8] diff.c: compute reverse locally in emit_line_0

2018-08-13 Thread Johannes Schindelin
Hi, On Fri, 10 Aug 2018, Stefan Beller wrote: > Signed-off-by: Stefan Beller > Signed-off-by: Junio C Hamano Well, my rationale for having the explicit `reverse` parameter is: this code is complex enough, introducing some magic "this and that implies this" makes it much harder to understand.

[PATCH 7/8] diff.c: compute reverse locally in emit_line_0

2018-08-10 Thread Stefan Beller
Signed-off-by: Stefan Beller Signed-off-by: Junio C Hamano --- diff.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/diff.c b/diff.c index 01095a59d3d..e50cd312755 100644 --- a/diff.c +++ b/diff.c @@ -622,11 +622,12 @@ static void check_blank_at_eof(mmfile_t

[PATCH 7/8] diff.c: compute reverse locally in emit_line_0

2018-07-30 Thread Stefan Beller
Signed-off-by: Stefan Beller --- diff.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/diff.c b/diff.c index fdad7ffdd77..f565a2c0c2b 100644 --- a/diff.c +++ b/diff.c @@ -576,11 +576,12 @@ static void check_blank_at_eof(mmfile_t *mf1, mmfile_t *mf2, }

[PATCH 7/8] diff.c: compute reverse locally in emit_line_0

2018-07-27 Thread Stefan Beller
Signed-off-by: Stefan Beller --- diff.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/diff.c b/diff.c index fdad7ffdd77..f565a2c0c2b 100644 --- a/diff.c +++ b/diff.c @@ -576,11 +576,12 @@ static void check_blank_at_eof(mmfile_t *mf1, mmfile_t *mf2, }