Re: [PATCH 8/7] cat-file: sort and de-dup output of --batch-all-objects

2015-06-22 Thread Charles Bailey
On Mon, Jun 22, 2015 at 07:06:32AM -0400, Jeff King wrote: On Mon, Jun 22, 2015 at 06:33:21AM -0400, Jeff King wrote: By the way, in addition to not showing objects in order, list-all-objects (and my cat-file option) may show duplicates. Do we want to sort -u for the user? It might be

Re: [PATCH 8/7] cat-file: sort and de-dup output of --batch-all-objects

2015-06-22 Thread Jeff King
On Mon, Jun 22, 2015 at 11:03:50PM +0100, Charles Bailey wrote: The patch below does the sort/de-dup. I'd probably just squash it into patch 7, though. Woah, 8 out of 7! Did you get a chance to measure the performance hit of the sort? If not, I may test it out when I next get the chance.

[PATCH 8/7] cat-file: sort and de-dup output of --batch-all-objects

2015-06-22 Thread Jeff King
On Mon, Jun 22, 2015 at 06:33:21AM -0400, Jeff King wrote: By the way, in addition to not showing objects in order, list-all-objects (and my cat-file option) may show duplicates. Do we want to sort -u for the user? It might be nice for them to always get a de-duped and sorted list. Aside from