Re: [PATCH 9/9] builtin/fetch: check for submodule updates for non branch fetches

2018-10-17 Thread Jonathan Tan
> @@ -887,11 +887,14 @@ static int store_updated_refs(const char *raw_url, > const char *remote_name, > rc |= update_local_ref(ref, what, rm, , > summary_width); > free(ref); > -

[PATCH 9/9] builtin/fetch: check for submodule updates for non branch fetches

2018-10-16 Thread Stefan Beller
Gerrit, the code review tool, has a different workflow than our mailing list based approach. Usually users upload changes to a Gerrit server and continuous integration and testing happens by bots. Sometimes however a user wants to checkout a change locally and look at it locally. For this use

[PATCH 9/9] builtin/fetch: check for submodule updates for non branch fetches

2018-09-17 Thread Stefan Beller
Gerrit, the code review tool, has a different workflow than our mailing list based approach. Usually users upload changes to a Gerrit server and continuous integration and testing happens by bots. Sometimes however a user wants to checkout a change locally and look at it locally. For this use

Re: [PATCH 9/9] builtin/fetch: check for submodule updates for non branch fetches

2018-09-12 Thread Junio C Hamano
Stefan Beller writes: > For Gerrit users that use submodules the invocation of fetch without a > branch is their main use case. That's way under explains this commit. It is totally unclear how that statement of fact relates to the problem this patch is trying to address; it does not even make

[PATCH 9/9] builtin/fetch: check for submodule updates for non branch fetches

2018-09-11 Thread Stefan Beller
For Gerrit users that use submodules the invocation of fetch without a branch is their main use case. Signed-off-by: Stefan Beller --- builtin/fetch.c | 5 - t/t5526-fetch-submodules.sh | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/builtin/fetch.c