Re: [PATCH 9/9] clone: run check_everything_connected

2013-03-31 Thread Duy Nguyen
On Thu, Mar 28, 2013 at 07:40:51AM +0700, Duy Nguyen wrote: Maybe we could do it in index-pack to save some (wall) time. I haven't tried but I think it might work. The problem is to make sure the pack contains objects for all sha1 references in the pack. By that description, we don't need to

Re: [PATCH 9/9] clone: run check_everything_connected

2013-03-26 Thread Junio C Hamano
Jeff King p...@peff.net writes: The slowdown is really quite terrible if you try git clone --bare linux-2.6.git. Even with this, the local-clone case already misses blob corruption. So it probably makes sense to restrict it to just the non-local clone case, which already has to do more work.

Re: [PATCH 9/9] clone: run check_everything_connected

2013-03-26 Thread Jeff King
On Tue, Mar 26, 2013 at 07:53:42AM +0700, Nguyen Thai Ngoc Duy wrote: On Tue, Mar 26, 2013 at 3:26 AM, Jeff King p...@peff.net wrote: static void update_remote_refs(const struct ref *refs, const struct ref *mapped_refs, const

[PATCH 9/9] clone: run check_everything_connected

2013-03-25 Thread Jeff King
When we fetch from a remote, we do a revision walk to make sure that what we received is connected to our existing history. We do not do the same check for clone, which should be able to check that we received an intact history graph. The upside of this patch is that it will make clone more

Re: [PATCH 9/9] clone: run check_everything_connected

2013-03-25 Thread Duy Nguyen
On Tue, Mar 26, 2013 at 3:26 AM, Jeff King p...@peff.net wrote: static void update_remote_refs(const struct ref *refs, const struct ref *mapped_refs, const struct ref *remote_head_points_at, const