[PATCH 9/9] git_config_set: reuse empty sections

2018-03-29 Thread Johannes Schindelin
It can happen quite easily that the last setting in a config section is removed, and to avoid confusion when there are comments in the config about that section, we keep a lone section header, i.e. an empty section. The code to add new entries in the config tries to be cute by reusing the parsing

Re: [PATCH 9/9] git_config_set: reuse empty sections

2018-03-29 Thread Jeff King
On Thu, Mar 29, 2018 at 05:19:09PM +0200, Johannes Schindelin wrote: > It can happen quite easily that the last setting in a config section is > removed, and to avoid confusion when there are comments in the config > about that section, we keep a lone section header, i.e. an empty > section. > >

Re: [PATCH 9/9] git_config_set: reuse empty sections

2018-03-30 Thread Johannes Schindelin
Hi Peff, On Thu, 29 Mar 2018, Jeff King wrote: > On Thu, Mar 29, 2018 at 05:19:09PM +0200, Johannes Schindelin wrote: > > > It can happen quite easily that the last setting in a config section is > > removed, and to avoid confusion when there are comments in the config > > about that section, we