Re: [PATCH RESEND v2] path: Fix a sparse warning

2013-05-29 Thread Ramsay Jones
Torsten Bögershausen wrote: > On 2013-05-28 19.04, Junio C Hamano wrote: >> >> Can you tell me what the conclusion on the discussion on your two >> other patches on 'pu'? >> >> * rj/mingw-cygwin (2013-05-08) 2 commits >> - cygwin: Remove the CYGWIN_V15_WIN32API build variable >> - mingw: rename W

Re: [PATCH RESEND v2] path: Fix a sparse warning

2013-05-29 Thread Torsten Bögershausen
On 2013-05-28 19.04, Junio C Hamano wrote: > > Can you tell me what the conclusion on the discussion on your two > other patches on 'pu'? > > * rj/mingw-cygwin (2013-05-08) 2 commits > - cygwin: Remove the CYGWIN_V15_WIN32API build variable > - mingw: rename WIN32 cpp macro to GIT_WINDOWS_NATIV

Re: [PATCH RESEND v2] path: Fix a sparse warning

2013-05-28 Thread Junio C Hamano
Ramsay Jones writes: > On MinGW, sparse issues an "'get_st_mode_bits' not declared. Should > it be static?" warning. The MinGW and MSVC builds do not see the > declaration of this function, within git-compat-util.h, due to its > placement within an preprocessor conditional. > > In order to suppre

[PATCH RESEND v2] path: Fix a sparse warning

2013-05-27 Thread Ramsay Jones
On MinGW, sparse issues an "'get_st_mode_bits' not declared. Should it be static?" warning. The MinGW and MSVC builds do not see the declaration of this function, within git-compat-util.h, due to its placement within an preprocessor conditional. In order to suppress the warning, we simply move th