Re: [PATCH RFC] CYGWIN: avoid implicit declaration warning

2014-11-24 Thread Torsten Bögershausen
It depends what we mean with old: cygwin 1.5 is old, and I lost my test installation this summer: One netbook was converted from XP to Linux, the other machine needs to be re-installed and CYGWIN 1.5 is no longer available for download. I can confirm that Ramsays patch works with CYGWIN

Re: [PATCH RFC] CYGWIN: avoid implicit declaration warning

2014-11-24 Thread Jonathan Nieder
Torsten Bögershausen wrote: gcc under cygwin reports several warnings like this: warning: implicit declaration of function 'memmem' [-Wimplicit-function-declaration] This has been observed under CYGWIN-32 with GCC 4.7.3 as well as CYGWIN-64 with gcc v4.8.3-5 x86-64 Do not #define

Re: [PATCH RFC] CYGWIN: avoid implicit declaration warning

2014-11-24 Thread Torsten Bögershausen
Patch looks good to me. Do you know if this has been reported to the Cygwin maintainers? The behavior seems counterintuitive --- I would expect _GNU_SOURCE to override everything else (since I thought that was the point of _GNU_SOURCE). I don't know, it seems that CYGWIN is now in class

Re: [PATCH RFC] CYGWIN: avoid implicit declaration warning

2014-11-24 Thread Ramsay Jones
On 24/11/14 07:20, Torsten Bögershausen wrote: On 2014-11-24 00.15, Ramsay Jones wrote: On 23/11/14 18:53, Junio C Hamano wrote: Ramsay Jones ram...@ramsay1.demon.co.uk writes: On 23/11/14 14:16, Torsten Bögershausen wrote: gcc under cygwin reports several warnings like this: warning:

Re: [PATCH RFC] CYGWIN: avoid implicit declaration warning

2014-11-24 Thread Ramsay Jones
On 24/11/14 17:59, Jonathan Nieder wrote: Torsten Bögershausen wrote: gcc under cygwin reports several warnings like this: warning: implicit declaration of function 'memmem' [-Wimplicit-function-declaration] This has been observed under CYGWIN-32 with GCC 4.7.3 as well as CYGWIN-64

Re: [PATCH RFC] CYGWIN: avoid implicit declaration warning

2014-11-24 Thread Junio C Hamano
Ramsay Jones ram...@ramsay1.demon.co.uk writes: I updated from cygwin 1.5 to cygwin 1.7 at the beginning of the year. Since it is no longer supported, I don't think we need to worry about version 1.5. When I said 'old installation' I meant my old version 1.7 32-bit installation. One netbook

Re: [PATCH RFC] CYGWIN: avoid implicit declaration warning

2014-11-24 Thread Ramsay Jones
On 23/11/14 23:15, Ramsay Jones wrote: On 23/11/14 18:53, Junio C Hamano wrote: Ramsay Jones ram...@ramsay1.demon.co.uk writes: On 23/11/14 14:16, Torsten Bögershausen wrote: gcc under cygwin reports several warnings like this: warning: implicit declaration of function 'memmem'

Re: [PATCH RFC] CYGWIN: avoid implicit declaration warning

2014-11-24 Thread Junio C Hamano
Ramsay Jones ram...@ramsay1.demon.co.uk writes: ... Although I have not done an actual diff of the various cdef.h files, they do appear to be more or less the same. In other words, I no longer think that the change results from a 'change in priority of _XOPEN_SOURCE'. The issue is simply

Re: [PATCH RFC] CYGWIN: avoid implicit declaration warning

2014-11-24 Thread Ramsay Jones
On 24/11/14 21:44, Junio C Hamano wrote: Ramsay Jones ram...@ramsay1.demon.co.uk writes: I updated from cygwin 1.5 to cygwin 1.7 at the beginning of the year. Since it is no longer supported, I don't think we need to worry about version 1.5. When I said 'old installation' I meant my old

Re: [PATCH RFC] CYGWIN: avoid implicit declaration warning

2014-11-24 Thread Ramsay Jones
On 24/11/14 22:50, Junio C Hamano wrote: Ramsay Jones ram...@ramsay1.demon.co.uk writes: ... Although I have not done an actual diff of the various cdef.h files, they do appear to be more or less the same. In other words, I no longer think that the change results from a 'change in priority

[PATCH RFC] CYGWIN: avoid implicit declaration warning

2014-11-23 Thread Torsten Bögershausen
gcc under cygwin reports several warnings like this: warning: implicit declaration of function 'memmem' [-Wimplicit-function-declaration] This has been observed under CYGWIN-32 with GCC 4.7.3 as well as CYGWIN-64 with gcc v4.8.3-5 x86-64 Do not #define _XOPEN_SOURCE 600 for CYGWIN.

Re: [PATCH RFC] CYGWIN: avoid implicit declaration warning

2014-11-23 Thread Ramsay Jones
On 23/11/14 14:16, Torsten Bögershausen wrote: gcc under cygwin reports several warnings like this: warning: implicit declaration of function 'memmem' [-Wimplicit-function-declaration] This has been observed under CYGWIN-32 with GCC 4.7.3 as well as CYGWIN-64 with gcc v4.8.3-5 x86-64 Heh,

Re: [PATCH RFC] CYGWIN: avoid implicit declaration warning

2014-11-23 Thread Junio C Hamano
Ramsay Jones ram...@ramsay1.demon.co.uk writes: On 23/11/14 14:16, Torsten Bögershausen wrote: gcc under cygwin reports several warnings like this: warning: implicit declaration of function 'memmem' [-Wimplicit-function-declaration] This has been observed under CYGWIN-32 with GCC 4.7.3 as

Re: [PATCH RFC] CYGWIN: avoid implicit declaration warning

2014-11-23 Thread Ramsay Jones
On 23/11/14 18:53, Junio C Hamano wrote: Ramsay Jones ram...@ramsay1.demon.co.uk writes: On 23/11/14 14:16, Torsten Bögershausen wrote: gcc under cygwin reports several warnings like this: warning: implicit declaration of function 'memmem' [-Wimplicit-function-declaration] This has been

Re: [PATCH RFC] CYGWIN: avoid implicit declaration warning

2014-11-23 Thread Torsten Bögershausen
On 2014-11-24 00.15, Ramsay Jones wrote: On 23/11/14 18:53, Junio C Hamano wrote: Ramsay Jones ram...@ramsay1.demon.co.uk writes: On 23/11/14 14:16, Torsten Bögershausen wrote: gcc under cygwin reports several warnings like this: warning: implicit declaration of function 'memmem'