Re: [PATCH RFC v2 01/19] rebase -i: Failed reword prints redundant error message

On Tue, Jul 8, 2014 at 4:31 PM, Junio C Hamano gits...@pobox.com wrote: Fabian Ruch baf...@gmail.com writes: It is true that a failed hook script might not output any diagnosis... I think the message originally came from 0becb3e4 (rebase -i: interrupt rebase when commit --amend failed during

Re: [PATCH RFC v2 01/19] rebase -i: Failed reword prints redundant error message

Hi Andrew, thanks for your review and sorry that I forgot to cc the bug fix to you. Andrew Wong writes: On Tue, Jul 8, 2014 at 4:31 PM, Junio C Hamano gits...@pobox.com wrote: Fabian Ruch baf...@gmail.com writes: It is true that a failed hook script might not output any diagnosis... I think

Re: [PATCH RFC v2 01/19] rebase -i: Failed reword prints redundant error message

On Thu, Jul 10, 2014 at 12:35 PM, Fabian Ruch baf...@gmail.com wrote: That is still taken care of by exit_with_patch here. Oh, that's right. Ok, go ahead and remove the third warning then. Thanks! -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to

Re: [PATCH RFC v2 01/19] rebase -i: Failed reword prints redundant error message

Fabian Ruch baf...@gmail.com writes: The to-do list command `reword` replays a commit like `pick` but lets the user also edit the commit's log message. If the edited log message is empty or is found ill-formatted by one of the commit hooks, git-rebase--interactive prints three error messages

[PATCH RFC v2 01/19] rebase -i: Failed reword prints redundant error message

The to-do list command `reword` replays a commit like `pick` but lets the user also edit the commit's log message. If the edited log message is empty or is found ill-formatted by one of the commit hooks, git-rebase--interactive prints three error messages to the console. 1. The git-commit