[PATCH V2] commit.c: Use skip_prefix() instead of starts_with()

In record_author_date() parse_gpg_output() ,using skip_prefix() instead of starts_with() is more elegant and abstracts away the details. Helped-by: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: Tanay Abhra tanay...@gmail.com --- Patch V2 Corrected email formatting ,reapplied the

Re: [PATCH V2] commit.c: Use skip_prefix() instead of starts_with()

Tanay Abhra tanay...@gmail.com writes: In record_author_date() parse_gpg_output() ,using skip_prefix() instead of starts_with() is more elegant and abstracts away the details. Avoid subjective judgement like more elegant when justifying your change; you are not your own judge. The caller of

Re: [PATCH V2] commit.c: Use skip_prefix() instead of starts_with()

On 03.03.2014, at 20:43, Junio C Hamano gits...@pobox.com wrote: Tanay Abhra tanay...@gmail.com writes: @@ -1193,9 +1194,9 @@ static void parse_gpg_output(struct signature_check *sigc) for (i = 0; i ARRAY_SIZE(sigcheck_gpg_status); i++) { const char *found, *next; -

Re: [PATCH V2] commit.c: Use skip_prefix() instead of starts_with()

Max Horn m...@quendi.de writes: On 03.03.2014, at 20:43, Junio C Hamano gits...@pobox.com wrote: Tanay Abhra tanay...@gmail.com writes: @@ -1193,9 +1194,9 @@ static void parse_gpg_output(struct signature_check *sigc) for (i = 0; i ARRAY_SIZE(sigcheck_gpg_status); i++) {