Re: [PATCH V3] git clone: is an URL local or ssh

2013-10-30 Thread Johannes Sixt
Am 10/29/2013 22:07, schrieb Torsten Bögershausen: > @@ -610,17 +623,17 @@ struct child_process *git_connect(int fd[2], const char > *url_orig, > } else > end = host; > > - path = strchr(end, c); > - if (path && !has_dos_drive_prefix(end)) { > - if (c == '

Re: [PATCH V3] git clone: is an URL local or ssh

2013-10-29 Thread Johannes Sixt
Just a heads-up: This patch breaks t5601 totally on Windows. Test #4, a local clone via file: protocol, fails already. I'm investigating now. -- Hannes -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at ht

Re: [PATCH V3] git clone: is an URL local or ssh

2013-10-29 Thread Jeff King
On Tue, Oct 29, 2013 at 10:07:50PM +0100, Torsten Bögershausen wrote: > Changes since V2: > clear_ssh and expect_ssh did come back > And I couldn't get it working without the > >"$TRASH_DIRECTORY/ssh-output" Thanks. > test_when_finished: > I could not get that to work. Probably because of

[PATCH V3] git clone: is an URL local or ssh

2013-10-29 Thread Torsten Bögershausen
Commit 8d3d28f5 added test cases for URLs which should be ssh. Add more tests testing all the combinations: -IPv4 or IPv6 -path starting with "/" or with "/~" -with and without the ssh:// scheme Add tests for ssh:// with port number. When a git repository "foo:bar" exist, git clone will call