Re: [PATCH master] convert: The native line-ending is \r\n on MinGW

2013-08-13 Thread Tvangeste
Brice Lambson bricelam at live.com writes: +1, this is a significant issue downstream in Git for Windows: https://github.com/msysgit/git/issues/57 Effectively this renders .gitattributes useless for the scenario of enforcing normalized line ending characters. +100 Folks, the problem is

Re: [PATCH master] convert: The native line-ending is \r\n on MinGW

2013-08-13 Thread Junio C Hamano
Tvangeste i.4m.l...@yandex.ru writes: Brice Lambson bricelam at live.com writes: +1, this is a significant issue downstream in Git for Windows: https://github.com/msysgit/git/issues/57 Effectively this renders .gitattributes useless for the scenario of enforcing normalized line ending

Re: [PATCH master] convert: The native line-ending is \r\n on MinGW

2013-04-16 Thread Erik Faye-Lund
On Mon, Apr 15, 2013 at 11:43 PM, Junio C Hamano gits...@pobox.com wrote: Erik Faye-Lund kusmab...@gmail.com writes: This is absolutely the right thing to do. However, stuff have changed a bit since the patch was written; this change now needs to go in config.mak.uname instead of config.mak.

Re: [PATCH master] convert: The native line-ending is \r\n on MinGW

2013-04-16 Thread Johannes Sixt
Am 16.04.2013 16:39, schrieb Erik Faye-Lund: On Mon, Apr 15, 2013 at 11:43 PM, Junio C Hamano gits...@pobox.com wrote: Erik Faye-Lund kusmab...@gmail.com writes: This is absolutely the right thing to do. However, stuff have changed a bit since the patch was written; this change now needs to

Re: [PATCH master] convert: The native line-ending is \r\n on MinGW

2013-04-16 Thread Junio C Hamano
Johannes Sixt j...@kdbg.org writes: I agree. I don't think we need it in maint; we don't track that branch for msysGit. Yes, master is good enough. Thanks to all those involved. Applied. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to

Re: [PATCH master] convert: The native line-ending is \r\n on MinGW

2013-04-15 Thread Brice Lambson
Mr_and_Mrs_D the.ubik at gmail.com writes: I am on windows 7 Pro - mingwin I decided to turn autocrlf to false and use .gitattributes instead and was bitten by this bug : http://stackoverflow.com/questions/13531988/git-line-endings-renormalize-

Re: [PATCH master] convert: The native line-ending is \r\n on MinGW

2013-04-15 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: Jonathan Nieder jrnie...@gmail.com writes: If you try this: 1. Install Git for Windows (from the msysgit project) 2. Put [core] autocrlf = false eol = native in your .gitconfig. 3. Clone a project with

Re: [PATCH master] convert: The native line-ending is \r\n on MinGW

2013-04-15 Thread Erik Faye-Lund
On Mon, Apr 15, 2013 at 11:00 PM, Junio C Hamano gits...@pobox.com wrote: Junio C Hamano gits...@pobox.com writes: Jonathan Nieder jrnie...@gmail.com writes: If you try this: 1. Install Git for Windows (from the msysgit project) 2. Put [core] autocrlf = false

Re: [PATCH master] convert: The native line-ending is \r\n on MinGW

2013-04-15 Thread Junio C Hamano
Erik Faye-Lund kusmab...@gmail.com writes: This is absolutely the right thing to do. However, stuff have changed a bit since the patch was written; this change now needs to go in config.mak.uname instead of config.mak. Thanks for a quick response. What's your preference? I could just ignore