Re: [PATCH revised] git_mkstemps: add test suite test

2013-08-06 Thread Junio C Hamano
wor...@alum.mit.edu (Dale R. Worley) writes: >> git commit --allow-empty -m message <&- > > Though as of [fb56570] "Sync with maint to grab trivial doc fixes", > that test doesn't fail for me if I revert to > > fd = open(pattern, O_CREAT | O_EXCL | O_RDWR, mode); >

Re: [PATCH revised] git_mkstemps: add test suite test

2013-08-06 Thread Dale R. Worley
> git commit --allow-empty -m message <&- Though as of [fb56570] "Sync with maint to grab trivial doc fixes", that test doesn't fail for me if I revert to fd = open(pattern, O_CREAT | O_EXCL | O_RDWR, mode); if (fd > 0) return fd; I hav

Re: [PATCH revised] git_mkstemps: add test suite test

2013-08-06 Thread Dale R. Worley
> From: Junio C Hamano > > Thanks. I thought I've already queued > > Message-ID: <7vfvuokpr0@alter.siamese.dyndns.org> > aka > http://article.gmane.org/gmane.comp.version-control.git/231680 > > which tests > > git commit --allow-empty -m message <&- My mistake... I've been so inten

Re: [PATCH revised] git_mkstemps: add test suite test

2013-08-06 Thread Junio C Hamano
wor...@alum.mit.edu (Dale R. Worley) writes: > Commit a2cb86 ("git_mkstemps: correctly test return value of open()", > 12 Jul 2013) fixes a bug regarding testing the return of an open() > call for success/failure. Add a testsuite test for that fix. The > test exercises a situation where that ope

[PATCH revised] git_mkstemps: add test suite test

2013-08-06 Thread Dale R. Worley
Commit a2cb86 ("git_mkstemps: correctly test return value of open()", 12 Jul 2013) fixes a bug regarding testing the return of an open() call for success/failure. Add a testsuite test for that fix. The test exercises a situation where that open() is known to return 0. Signed-off-by: Dale Worley