Re: [PATCH v1] annotate: skip checking working tree if a revision is provided

2015-11-20 Thread Edmundo Carmona Antoranz
On Tue, Nov 17, 2015 at 7:20 PM, Edmundo Carmona Antoranz wrote: > + if (!revs.pending.nr && !file_exists(path)) > + die_errno("cannot stat path '%s'", path); > + I was wondering if I should only check the path that is coming from "blame" (which is where

Re: [PATCH v1] annotate: skip checking working tree if a revision is provided

2015-11-20 Thread Edmundo Carmona Antoranz
And I did't say it right. The execution path where dashdash_pos is 0 is coming from "annotate". Sorry for my confusion on the previous mail. On Fri, Nov 20, 2015 at 7:25 PM, Edmundo Carmona Antoranz wrote: > On Tue, Nov 17, 2015 at 7:20 PM, Edmundo Carmona Antoranz >

[PATCH v1] annotate: skip checking working tree if a revision is provided

2015-11-17 Thread Edmundo Carmona Antoranz
If a file has been deleted/renamed, annotate refuses to work because the file does not exist on the working tree anymore (even if the path provided does match a blob on said revision). Signed-off-by: Edmundo Carmona Antoranz --- builtin/blame.c | 5 +++--