Re: [PATCH v1] checkout: optionally speed up "git checkout -b foo"

2018-07-26 Thread Eric Sunshine
On Thu, Jul 26, 2018 at 2:59 PM Eric Sunshine wrote: > On Thu, Jul 26, 2018 at 11:04 AM Junio C Hamano wrote: > > If there were a simple and futureproof way to tell the option > > parsing loop to notice any feature other than "-b newbranch" was > > used, then such a whitelisting may be a viable w

Re: [PATCH v1] checkout: optionally speed up "git checkout -b foo"

2018-07-26 Thread Eric Sunshine
On Thu, Jul 26, 2018 at 11:04 AM Junio C Hamano wrote: > Ben Peart writes: > > I'm not thrilled with the long list either (the plethora of comments > > probably makes it appear worse than it is) but I don't see how... > > If there were a simple and futureproof way to tell the option > parsing loo

Re: [PATCH v1] checkout: optionally speed up "git checkout -b foo"

2018-07-26 Thread Junio C Hamano
Ben Peart writes: [jc: it was a bit surprising that Eric covered all the bits I covered while we were writing without peeking each other's ;-)] >> This long list of special-case checks doesn't leave me too enthused, >> however, that aside, this approach seems backward. Rather than erring >> on t

Re: [PATCH v1] checkout: optionally speed up "git checkout -b foo"

2018-07-24 Thread Ben Peart
On 7/24/2018 3:21 PM, Junio C Hamano wrote: Ben Peart writes: From: Ben Peart If the new core.optimizecheckout config setting is set to true, speed up "git checkout -b foo" by avoiding the work to merge the working tree. This is valid because no merge needs to occur - only creating the n

Re: [PATCH v1] checkout: optionally speed up "git checkout -b foo"

2018-07-24 Thread Ben Peart
On 7/24/2018 2:42 PM, Eric Sunshine wrote: On Tue, Jul 24, 2018 at 2:01 PM Ben Peart wrote: If the new core.optimizecheckout config setting is set to true, speed up Maybe: Add core.optimizeCheckout config setting which, when true, speeds up Sure "git checkout -b foo" by avoiding

Re: [PATCH v1] checkout: optionally speed up "git checkout -b foo"

2018-07-24 Thread Junio C Hamano
Ben Peart writes: > From: Ben Peart > > If the new core.optimizecheckout config setting is set to true, speed up > "git checkout -b foo" by avoiding the work to merge the working tree. This > is valid because no merge needs to occur - only creating the new branch/ > updating the refs. Any other

Re: [PATCH v1] checkout: optionally speed up "git checkout -b foo"

2018-07-24 Thread Eric Sunshine
On Tue, Jul 24, 2018 at 2:01 PM Ben Peart wrote: > If the new core.optimizecheckout config setting is set to true, speed up Maybe: Add core.optimizeCheckout config setting which, when true, speeds up > "git checkout -b foo" by avoiding the work to merge the working tree. This > is valid be

[PATCH v1] checkout: optionally speed up "git checkout -b foo"

2018-07-24 Thread Ben Peart
From: Ben Peart If the new core.optimizecheckout config setting is set to true, speed up "git checkout -b foo" by avoiding the work to merge the working tree. This is valid because no merge needs to occur - only creating the new branch/ updating the refs. Any other options force it through the o