Re: [PATCH v1] config.c: fix msvc compile error

2018-07-25 Thread Jeff Hostetler
On 7/24/2018 3:56 PM, Taylor Blau wrote: On Tue, Jul 24, 2018 at 03:30:10PM +, g...@jeffhostetler.com wrote: From: Jeff Hostetler In commit fb0dc3bac135e9f6243bd6d293e8c9293c73b9cd code was added to builtin/config.c to define a new function and a forward declaration for an array of unkn

Re: [PATCH v1] config.c: fix msvc compile error

2018-07-24 Thread Taylor Blau
On Tue, Jul 24, 2018 at 03:30:10PM +, g...@jeffhostetler.com wrote: > From: Jeff Hostetler > > In commit fb0dc3bac135e9f6243bd6d293e8c9293c73b9cd code was added > to builtin/config.c to define a new function and a forward declaration > for an array of unknown size. This causes a compile error

Re: [PATCH v1] config.c: fix msvc compile error

2018-07-24 Thread Beat Bolli
On 24.07.18 20:50, Junio C Hamano wrote: > Beat Bolli writes: > >> On 24.07.18 20:22, Junio C Hamano wrote: >> This was already fixed (differently) in <20180705183445.30901-1-dev+...@drbeat.li>. >>> >>> Thanks for saving me from having to dig the list archive myself. >>> Yes, it is alre

Re: [PATCH v1] config.c: fix msvc compile error

2018-07-24 Thread Junio C Hamano
Beat Bolli writes: > On 24.07.18 20:22, Junio C Hamano wrote: > >>> This was already fixed (differently) in >>> <20180705183445.30901-1-dev+...@drbeat.li>. >> >> Thanks for saving me from having to dig the list archive myself. >> Yes, it is already applied to the tip of the topic that originally

Re: [PATCH v1] config.c: fix msvc compile error

2018-07-24 Thread Beat Bolli
On 24.07.18 20:22, Junio C Hamano wrote: > Beat Bolli writes: > >> Hi Jeff >> >> On 24.07.18 17:30, g...@jeffhostetler.com wrote: >>> From: Jeff Hostetler >>> >>> In commit fb0dc3bac135e9f6243bd6d293e8c9293c73b9cd code was added >>> to builtin/config.c to define a new function and a forward decl

Re: [PATCH v1] config.c: fix msvc compile error

2018-07-24 Thread Junio C Hamano
Beat Bolli writes: > Hi Jeff > > On 24.07.18 17:30, g...@jeffhostetler.com wrote: >> From: Jeff Hostetler >> >> In commit fb0dc3bac135e9f6243bd6d293e8c9293c73b9cd code was added >> to builtin/config.c to define a new function and a forward declaration >> for an array of unknown size. This caus

Re: [PATCH v1] config.c: fix msvc compile error

2018-07-24 Thread Beat Bolli
Hi Jeff On 24.07.18 17:30, g...@jeffhostetler.com wrote: > From: Jeff Hostetler > > In commit fb0dc3bac135e9f6243bd6d293e8c9293c73b9cd code was added > to builtin/config.c to define a new function and a forward declaration > for an array of unknown size. This causes a compile error under MSVC.

Re: [PATCH v1] config.c: fix msvc compile error

2018-07-24 Thread Junio C Hamano
g...@jeffhostetler.com writes: > From: Jeff Hostetler > > In commit fb0dc3bac135e9f6243bd6d293e8c9293c73b9cd code was added > to builtin/config.c to define a new function and a forward declaration > for an array of unknown size. This causes a compile error under MSVC. > > Reorder the code to for

[PATCH v1] config.c: fix msvc compile error

2018-07-24 Thread git
From: Jeff Hostetler In commit fb0dc3bac135e9f6243bd6d293e8c9293c73b9cd code was added to builtin/config.c to define a new function and a forward declaration for an array of unknown size. This causes a compile error under MSVC. Reorder the code to forward declare the function instead of the arr