Re: [PATCH v1] git-p4: fix git-p4.pathEncoding for removed files

2016-12-22 Thread Junio C Hamano
Luke Diamand writes: > The change puts the logic into stripRepoPath() instead, which is > indeed called from both of those functions (good), but also from > splitFilesIntoBranches(), but only if self.useClientSpec is set. That > function only gets used if we're doing the

Re: [PATCH v1] git-p4: fix git-p4.pathEncoding for removed files

2016-12-20 Thread Luke Diamand
On 19 December 2016 at 21:29, Junio C Hamano wrote: > larsxschnei...@gmail.com writes: > >> From: Lars Schneider >> >> In a9e38359e3 we taught git-p4 a way to re-encode path names from what >> was used in Perforce to UTF-8. This path re-encoding

Re: [PATCH v1] git-p4: fix git-p4.pathEncoding for removed files

2016-12-19 Thread Junio C Hamano
larsxschnei...@gmail.com writes: > From: Lars Schneider > > In a9e38359e3 we taught git-p4 a way to re-encode path names from what > was used in Perforce to UTF-8. This path re-encoding worked properly for > "added" paths. "Removed" paths were not re-encoded and

[PATCH v1] git-p4: fix git-p4.pathEncoding for removed files

2016-12-18 Thread larsxschneider
From: Lars Schneider In a9e38359e3 we taught git-p4 a way to re-encode path names from what was used in Perforce to UTF-8. This path re-encoding worked properly for "added" paths. "Removed" paths were not re-encoded and therefore different from the "added" paths.