Teach test-drop-caches to handle lower case drive letters on Windows.
Signed-off-by: Ben Peart
---
Notes:
Base Ref: master
Web-Diff: https://github.com/benpeart/git/commit/55b815ee73
Checkout: git fetch https://github.com/benpeart/git drop-caches-v1 && git
checkout 55b815ee73
t/he
On Wed, Jul 11, 2018 at 10:54 AM Ben Peart wrote:
>
> Teach test-drop-caches to handle lower case drive letters on Windows.
As someone not quite familiar with Windows (and using Git there),
is this addressing a user visible issue, or a developer visible issue?
(It looks to me as the latter as it
> -Original Message-
> From: Stefan Beller
> Sent: Wednesday, July 11, 2018 1:59 PM
> To: Ben Peart
> Cc: git ; Junio C Hamano
> Subject: Re: [PATCH v1] handle lower case drive letters on Windows
>
> On Wed, Jul 11, 2018 at 10:54 AM Ben Peart
> wrote:
> &
Ben Peart writes:
>> -Original Message-
>> From: Stefan Beller
>> Sent: Wednesday, July 11, 2018 1:59 PM
>> To: Ben Peart
>> Cc: git ; Junio C Hamano
>> Subject: Re: [PATCH v1] handle lower case drive letters on Windows
>>
>> On W
> -Original Message-
> From: Junio C Hamano On Behalf Of Junio C Hamano
> Sent: Wednesday, July 11, 2018 4:11 PM
> To: Ben Peart
> Cc: Stefan Beller ; git
> Subject: Re: [PATCH v1] handle lower case drive letters on Windows
>
> Ben Peart writes:
>
Hi Ben,
On Wed, 11 Jul 2018, Ben Peart wrote:
> Teach test-drop-caches to handle lower case drive letters on Windows.
Maybe mention that you can trigger this by using a lower case drive letter
in Powershell (CMD normalizes your path, Powershell does not).
> diff --git a/t/helper/test-drop-cache
Johannes Schindelin writes:
> So maybe a much better idea is to use our `has_dos_drive_prefix()`
> function:
>
> if (!has_dos_drive_prefix(Buffer))
> return error("'%s': invalid drive letter", Buffer);
"'%s': path without valid drive prefix", you mean?
7 matches
Mail list logo
