On Tue, Oct 23, 2018 at 03:13:06PM -0400, Ben Peart wrote:
> At one point I also had the additional #ifndef NO_PTHREADS lines but it was
> starting to get messy with the threaded vs non-threaded code paths so I
> removed them. I'm fine with which ever people find more readable.
>
> It does make
On 10/22/2018 7:05 PM, Junio C Hamano wrote:
Jeff King writes:
If nobody uses it, should we drop the return value, too? Like:
Yup.
I'm good with that.
At one point I also had the additional #ifndef NO_PTHREADS lines but it
was starting to get messy with the threaded vs non-threaded
Jeff King writes:
> If nobody uses it, should we drop the return value, too? Like:
Yup.
>
> diff --git a/read-cache.c b/read-cache.c
> index 78c9516eb7..4b44a2eae5 100644
> --- a/read-cache.c
> +++ b/read-cache.c
> @@ -2052,12 +2052,11 @@ static void *load_cache_entries_thread(void *_data)
>
On Mon, Oct 22, 2018 at 11:05:13AM -0400, Ben Peart wrote:
> From: Ben Peart
>
> Remove the src_offset parameter which is unused as a result of switching
> to the IEOT table of offsets. Also stop incrementing src_offset in the
> multi-threaded codepath as it is no longer used and could cause
From: Ben Peart
Remove the src_offset parameter which is unused as a result of switching
to the IEOT table of offsets. Also stop incrementing src_offset in the
multi-threaded codepath as it is no longer used and could cause confusion.
Signed-off-by: Ben Peart
---
Notes:
Base Ref:
5 matches
Mail list logo