Re: [PATCH v1] travis-ci: build documentation

2016-04-25 Thread Junio C Hamano
Matthieu Moy writes: > Actually, this may also be a motivation to move anything non-trivial out > of .travic.yml and to start using separate scripts (to avoid writting > shell within a Yaml syntax). Excellent suggestion. I do not mind if we added a new directory

Re: [PATCH v1] travis-ci: build documentation

2016-04-25 Thread Matthieu Moy
Junio C Hamano writes: > Junio C Hamano writes: > >> Lars Schneider writes: >> There also are existing instances of "useless ;" that would want to be cleaned up regardless of portability issues. >>> Unfortunately it

Re: [PATCH v1] travis-ci: build documentation

2016-04-25 Thread Junio C Hamano
Junio C Hamano writes: > Lars Schneider writes: > >>> There also are existing instances of "useless ;" that would want to >>> be cleaned up regardless of portability issues. >> Unfortunately it seems to be required. Travis CI generates a shell script

Re: [PATCH v1] travis-ci: build documentation

2016-04-25 Thread Jeff King
On Mon, Apr 25, 2016 at 10:35:24AM +0200, Lars Schneider wrote: > > This does slow down the normal test results for linux/gcc, though. I > > don't know very much about Travis, but is it possible to break out the > > documentation build into its own test, with a separate build status from > > the

Re: [PATCH v1] travis-ci: build documentation

2016-04-25 Thread Junio C Hamano
Lars Schneider writes: >> There also are existing instances of "useless ;" that would want to >> be cleaned up regardless of portability issues. > Unfortunately it seems to be required. Travis CI generates a shell script > out of the yml file and I think they don't

Re: [PATCH v1] travis-ci: build documentation

2016-04-25 Thread Matthieu Moy
Lars Schneider writes: > On 22 Apr 2016, at 11:07, Matthieu Moy wrote: > >> The ; or the newline is not needed either. > Unfortunately it seems to be required. Travis CI generates a shell script > out of the yml file and I think they don't

Re: [PATCH v1] travis-ci: build documentation

2016-04-25 Thread Matthieu Moy
Junio C Hamano writes: > Matthieu Moy writes: > >> larsxschnei...@gmail.com writes: >> >>> + if [[ "$TRAVIS_OS_NAME" = linux ]] && [[ "$CC" = gcc ]]; >> >> [[ is a bashism, and doesn't bring anything here compared to the POSIX >> [ ... ], or

Re: [PATCH v1] travis-ci: build documentation

2016-04-25 Thread Lars Schneider
On 23 Apr 2016, at 05:39, Jeff King wrote: > On Fri, Apr 22, 2016 at 10:34:02AM +0200, larsxschnei...@gmail.com wrote: > >> From: Lars Schneider >> >> Run "make doc" to check if all documentation can be build without errors. >> Since the documentation

Re: [PATCH v1] travis-ci: build documentation

2016-04-25 Thread Lars Schneider
On 22 Apr 2016, at 20:14, Junio C Hamano wrote: > Matthieu Moy writes: > >> larsxschnei...@gmail.com writes: >> >>> + if [[ "$TRAVIS_OS_NAME" = linux ]] && [[ "$CC" = gcc ]]; >> >> [[ is a bashism, and doesn't bring anything here

Re: [PATCH v1] travis-ci: build documentation

2016-04-25 Thread Lars Schneider
On 22 Apr 2016, at 12:45, stefan.na...@atlas-elektronik.com wrote: > Am 22.04.2016 um 10:34 schrieb larsxschnei...@gmail.com: >> From: Lars Schneider >> >> Run "make doc" to check if all documentation can be build without errors. > > s/build/built/ Fixed. Thank you!

Re: [PATCH v1] travis-ci: build documentation

2016-04-25 Thread Lars Schneider
On 22 Apr 2016, at 11:07, Matthieu Moy wrote: > larsxschnei...@gmail.com writes: > >> + if [[ "$TRAVIS_OS_NAME" = linux ]] && [[ "$CC" = gcc ]]; > > [[ is a bashism, and doesn't bring anything here compared to the POSIX > [ ... ], or "test" which is prefered

Re: [PATCH v1] travis-ci: build documentation

2016-04-22 Thread Jeff King
On Fri, Apr 22, 2016 at 10:34:02AM +0200, larsxschnei...@gmail.com wrote: > From: Lars Schneider > > Run "make doc" to check if all documentation can be build without errors. > Since the documentation is the same on every platform/compiler, the check > is only

Re: [PATCH v1] travis-ci: build documentation

2016-04-22 Thread Junio C Hamano
Matthieu Moy writes: > larsxschnei...@gmail.com writes: > >> + if [[ "$TRAVIS_OS_NAME" = linux ]] && [[ "$CC" = gcc ]]; > > [[ is a bashism, and doesn't bring anything here compared to the POSIX > [ ... ], or "test" which is prefered in Git's source code. > >

Re: [PATCH v1] travis-ci: build documentation

2016-04-22 Thread stefan.naewe
Am 22.04.2016 um 10:34 schrieb larsxschnei...@gmail.com: > From: Lars Schneider > > Run "make doc" to check if all documentation can be build without errors. s/build/built/ > Since the documentation is the same on every platform/compiler, the check > is only

Re: [PATCH v1] travis-ci: build documentation

2016-04-22 Thread Matthieu Moy
larsxschnei...@gmail.com writes: > + if [[ "$TRAVIS_OS_NAME" = linux ]] && [[ "$CC" = gcc ]]; [[ is a bashism, and doesn't bring anything here compared to the POSIX [ ... ], or "test" which is prefered in Git's source code. The ; or the newline is not needed either. I'd write if test

[PATCH v1] travis-ci: build documentation

2016-04-22 Thread larsxschneider
From: Lars Schneider Run "make doc" to check if all documentation can be build without errors. Since the documentation is the same on every platform/compiler, the check is only performed as part of the Linux/GCC build job to maintain a fast CI process. Signed-off-by: