Re: [PATCH v1 0/5] Allocate cache entries from memory pool

2018-04-23 Thread Stefan Beller
On Mon, Apr 23, 2018 at 9:44 AM, Jameson Miller wrote: > I would be interested to understand how the > mem_pool would fit your needs, and if it is sufficient or needs modification > for your use cases. > >> [1] proof of concept in patches nearby >> https://public-inbox.org/git/20180206001749.21894

Re: [PATCH v1 0/5] Allocate cache entries from memory pool

2018-04-23 Thread Jameson Miller
On 04/20/2018 07:34 PM, Jonathan Tan wrote: On Tue, 17 Apr 2018 16:34:39 + Jameson Miller wrote: Jameson Miller (5): read-cache: teach refresh_cache_entry to take istate Add an API creating / discarding cache_entry structs mem-pool: fill out functionality Allocate cache entri

Re: [PATCH v1 0/5] Allocate cache entries from memory pool

2018-04-23 Thread Jameson Miller
On 04/20/2018 01:49 PM, Stefan Beller wrote: base-commit: cafaccae98f749ebf33495aec42ea25060de8682 I couldn't quite figure out what these five patches were based on, even with this line. Basing on and referring to a commit that is not part of our published history with "base-commit" is not a

Re: [PATCH v1 0/5] Allocate cache entries from memory pool

2018-04-23 Thread Jameson Miller
On 04/18/2018 12:49 AM, Junio C Hamano wrote: Jameson Miller writes: This patch series improves the performance of loading indexes by reducing the number of malloc() calls. ... Jameson Miller (5): read-cache: teach refresh_cache_entry to take istate Add an API creating / discarding ca

Re: [PATCH v1 0/5] Allocate cache entries from memory pool

2018-04-23 Thread Jameson Miller
On 04/17/2018 02:39 PM, Ben Peart wrote: On 4/17/2018 12:34 PM, Jameson Miller wrote: 100K Test   baseline [4] block_allocation 0002.1: read_cache/discard_cache 1 times 

Re: [PATCH v1 0/5] Allocate cache entries from memory pool

2018-04-20 Thread Jonathan Tan
On Tue, 17 Apr 2018 16:34:39 + Jameson Miller wrote: > Jameson Miller (5): > read-cache: teach refresh_cache_entry to take istate > Add an API creating / discarding cache_entry structs > mem-pool: fill out functionality > Allocate cache entries from memory pools > Add optional memor

Re: [PATCH v1 0/5] Allocate cache entries from memory pool

2018-04-20 Thread Stefan Beller
>> base-commit: cafaccae98f749ebf33495aec42ea25060de8682 > > I couldn't quite figure out what these five patches were based on, > even with this line. Basing on and referring to a commit that is > not part of our published history with "base-commit" is not all that > useful to others. I'd like to

Re: [PATCH v1 0/5] Allocate cache entries from memory pool

2018-04-17 Thread Junio C Hamano
Jameson Miller writes: > This patch series improves the performance of loading indexes by > reducing the number of malloc() calls. ... > > Jameson Miller (5): > read-cache: teach refresh_cache_entry to take istate > Add an API creating / discarding cache_entry structs > mem-pool: fill out f

Re: [PATCH v1 0/5] Allocate cache entries from memory pool

2018-04-17 Thread Ben Peart
On 4/17/2018 12:34 PM, Jameson Miller wrote: 100K Test baseline [4] block_allocation 0002.1: read_cache/discard_cache 1 times 0.03(0.01+0.01)0.02(0.01+0.01

[PATCH v1 0/5] Allocate cache entries from memory pool

2018-04-17 Thread Jameson Miller
This patch series improves the performance of loading indexes by reducing the number of malloc() calls. Loading the index from disk is partly dominated by the time in malloc(), which is called for each index entry. This patch series reduces the number of times malloc() is called as part of loading

[PATCH v1 0/5] Allocate cache entries from memory pool

2018-04-17 Thread Jameson Miller
This patch series improves the performance of loading indexes by reducing the number of malloc() calls. Loading the index from disk is partly dominated by the time in malloc(), which is called for each index entry. This patch series reduces the number of times malloc() is called as part of loading