Re: [PATCH v1 03/19] split-index: add {add,remove}_split_index() functions

2016-11-09 Thread Christian Couder
On Wed, Nov 9, 2016 at 10:24 AM, Duy Nguyen wrote: > On Mon, Nov 7, 2016 at 5:08 PM, Duy Nguyen wrote: >> On Sun, Oct 30, 2016 at 5:06 AM, Christian Couder >> wrote: >>> On Tue, Oct 25, 2016 at 11:58 AM, Duy Nguyen wrote: On Sun, Oct 23, 2016 at 4:26 PM, Christian Couder wrote: >

Re: [PATCH v1 03/19] split-index: add {add,remove}_split_index() functions

2016-11-09 Thread Duy Nguyen
On Mon, Nov 7, 2016 at 5:08 PM, Duy Nguyen wrote: > On Sun, Oct 30, 2016 at 5:06 AM, Christian Couder > wrote: >> On Tue, Oct 25, 2016 at 11:58 AM, Duy Nguyen wrote: >>> On Sun, Oct 23, 2016 at 4:26 PM, Christian Couder >>> wrote: +void remove_split_index(struct index_state *istate) +

Re: [PATCH v1 03/19] split-index: add {add,remove}_split_index() functions

2016-11-07 Thread Duy Nguyen
On Sun, Oct 30, 2016 at 5:06 AM, Christian Couder wrote: > On Tue, Oct 25, 2016 at 11:58 AM, Duy Nguyen wrote: >> On Sun, Oct 23, 2016 at 4:26 PM, Christian Couder >> wrote: >>> +void remove_split_index(struct index_state *istate) >>> +{ >>> + if (istate->split_index) { >>> +

Re: [PATCH v1 03/19] split-index: add {add,remove}_split_index() functions

2016-10-29 Thread Christian Couder
On Tue, Oct 25, 2016 at 11:58 AM, Duy Nguyen wrote: > On Sun, Oct 23, 2016 at 4:26 PM, Christian Couder > wrote: >> +void remove_split_index(struct index_state *istate) >> +{ >> + if (istate->split_index) { >> + /* >> +* can't discard_split_index(&the_index); b

Re: [PATCH v1 03/19] split-index: add {add,remove}_split_index() functions

2016-10-25 Thread Duy Nguyen
On Sun, Oct 23, 2016 at 4:26 PM, Christian Couder wrote: > +void remove_split_index(struct index_state *istate) > +{ > + if (istate->split_index) { > + /* > +* can't discard_split_index(&the_index); because that > +* will destroy split_index->bas

[PATCH v1 03/19] split-index: add {add,remove}_split_index() functions

2016-10-23 Thread Christian Couder
Also use the functions in cmd_update_index() in builtin/update-index.c. These functions will be used in a following commit to tweak our use of the split-index feature depending on the setting of a configuration variable. Signed-off-by: Christian Couder --- builtin/update-index.c | 18 ++