Re: [PATCH v1 03/25] structured-logging: add structured logging framework

2018-08-20 Thread Jonathan Nieder
Jeff Hostetler wrote: [...] > --- a/compat/mingw.h > +++ b/compat/mingw.h > @@ -144,8 +144,15 @@ static inline int fcntl(int fd, int cmd, ...) > errno = EINVAL; > return -1; > } > + > /* bash cannot reliably detect negative return codes as failure */ > +#if

Re: [PATCH v1 03/25] structured-logging: add structured logging framework

2018-07-27 Thread Jeff Hostetler
On 7/26/2018 5:09 AM, SZEDER Gábor wrote: +void slog_set_command_name(const char *command_name) +{ + /* +* Capture the command name even if logging is not enabled +* because we don't know if the config has been loaded yet by +* the cmd_() and/or it may be too

Re: [PATCH v1 03/25] structured-logging: add structured logging framework

2018-07-26 Thread SZEDER Gábor
> +void slog_set_command_name(const char *command_name) > +{ > + /* > + * Capture the command name even if logging is not enabled > + * because we don't know if the config has been loaded yet by > + * the cmd_() and/or it may be too early to force a > + * lazy load. > +

[PATCH v1 03/25] structured-logging: add structured logging framework

2018-07-13 Thread git
From: Jeff Hostetler Teach git to optionally generate structured logging data in JSON using the json-writer API. "cmd_start" and "cmd_end" events are generated. Structured logging is only available when git is built with STRUCTURED_LOGGING=1. Structured logging is only enabled when the config