Re: [PATCH v1 1/2] t/*: fix pipe placement and remove \'s

2018-09-17 Thread Matthew DeVore
On Mon, Sep 17, 2018 at 9:31 AM Jonathan Nieder wrote: > > Matthew DeVore wrote: > > > Subject: t/*: fix pipe placement and remove \'s > > > > Where ever there was code in the tests like this: > > > > foo \ > > | bar > > Language nits: > - s/Where ever/Wherever/ > - Git's

Re: [PATCH v1 1/2] t/*: fix pipe placement and remove \'s

2018-09-17 Thread Jonathan Nieder
Matthew DeVore wrote: > Subject: t/*: fix pipe placement and remove \'s > > Where ever there was code in the tests like this: > > foo \ > | bar Language nits: - s/Where ever/Wherever/ - Git's commit messages use the present tense to describe the existing previous state of

[PATCH v1 1/2] t/*: fix pipe placement and remove \'s

2018-09-14 Thread Matthew DeVore
Where ever there was code in the tests like this: foo \ | bar such as: git rev-list HEAD \ | grep $COMMIT replace it with this: foo | bar And add a blank line before and after the pipe where it aids readability (it usually