Re: [PATCH v1 2/8] Add initial odb remote support

Christian Couder writes: > For each promisor remote I think it makes no sense to have more than > one remote odb pointing to it. So I am not sure what to do here. If it makes no sense, then detecting and erroring out would be a sensible thing to do, no?

Re: [PATCH v1 2/8] Add initial odb remote support

On Tue, May 15, 2018 at 3:44 AM, Junio C Hamano wrote: > Christian Couder writes: >> --- /dev/null >> +++ b/odb-helper.h >> @@ -0,0 +1,13 @@ >> +#ifndef ODB_HELPER_H >> +#define ODB_HELPER_H > > Here is a good space to write a comment on what this structure and > its fields are about. Who are

Re: [PATCH v1 2/8] Add initial odb remote support

On Sun, May 13 2018, Christian Couder wrote: > "sha1_file.c"[...] sha1-file.c these days :)

Re: [PATCH v1 2/8] Add initial odb remote support

Christian Couder writes: > diff --git a/odb-helper.h b/odb-helper.h > new file mode 100644 > index 00..61d2ad082b > --- /dev/null > +++ b/odb-helper.h > @@ -0,0 +1,13 @@ > +#ifndef ODB_HELPER_H > +#define ODB_HELPER_H > + Here is a good space to write a

[PATCH v1 2/8] Add initial odb remote support

The odb-remote.{c,h} files will contain the functions that are called by the rest of Git mostly from "sha1_file.c" to access the objects managed by the odb remotes. The odb-helper.{c,h} files will contain the functions to actually implement communication with either the internal functions or the