Re: [PATCH v1 5/8] sequencer: don't die in print_commit_summary()

2017-11-13 Thread Phillip Wood
On 10/11/17 18:05, Junio C Hamano wrote: > Phillip Wood writes: > >> On 07/11/17 15:13, Junio C Hamano wrote: >> ... >>> Another possibility perhaps is that the function is safe to reuse >>> already even without this patch, of course ;-). >>> >> Hmm, maybe it is.

Re: [PATCH v1 5/8] sequencer: don't die in print_commit_summary()

2017-11-10 Thread Junio C Hamano
Phillip Wood writes: > On 07/11/17 15:13, Junio C Hamano wrote: > ... >> Another possibility perhaps is that the function is safe to reuse >> already even without this patch, of course ;-). >> > Hmm, maybe it is. Looking at pick_commits() and do_pick_commit() if the >

Re: [PATCH v1 5/8] sequencer: don't die in print_commit_summary()

2017-11-10 Thread Phillip Wood
On 07/11/17 15:13, Junio C Hamano wrote: > Junio C Hamano writes: > >> And this step is going in the right direction, but I am not sure if >> this made the function safe enough to be called repeatedly from the >> rebase machinery and we are ready to unleash this to the end

Re: [PATCH v1 5/8] sequencer: don't die in print_commit_summary()

2017-11-07 Thread Junio C Hamano
Junio C Hamano writes: > And this step is going in the right direction, but I am not sure if > this made the function safe enough to be called repeatedly from the > rebase machinery and we are ready to unleash this to the end users > and tell them it is safe to use it.

Re: [PATCH v1 5/8] sequencer: don't die in print_commit_summary()

2017-11-07 Thread Johannes Schindelin
Hi Junio, On Tue, 7 Nov 2017, Junio C Hamano wrote: > Phillip Wood writes: > > > From: Phillip Wood > > > > Return an error rather than dying so that the sequencer can exit > > cleanly once it starts committing without forking 'git

Re: [PATCH v1 5/8] sequencer: don't die in print_commit_summary()

2017-11-06 Thread Junio C Hamano
Phillip Wood writes: > From: Phillip Wood > > Return an error rather than dying so that the sequencer can exit > cleanly once it starts committing without forking 'git commit' > > Signed-off-by: Phillip Wood >

[PATCH v1 5/8] sequencer: don't die in print_commit_summary()

2017-11-06 Thread Phillip Wood
From: Phillip Wood Return an error rather than dying so that the sequencer can exit cleanly once it starts committing without forking 'git commit' Signed-off-by: Phillip Wood --- builtin/commit.c | 3 ++- sequencer.c | 17