Re: [PATCH v10 9/9] convert: add round trip check based on 'core.checkRoundtripEncoding'

> On 07 Mar 2018, at 23:52, Junio C Hamano wrote: > > Lars Schneider writes: > >> I don't think HT makes too much sense. However, isspace() is nice >> and I will use it. Being more permissive on the inputs should hurt. > > You are being incoherent

Re: [PATCH v10 9/9] convert: add round trip check based on 'core.checkRoundtripEncoding'

Lars Schneider writes: > Although the line is unnecessary, I felt it is safer/easier to > understand and maintain. Since both of you tripped over it, I will > remove it though. I didn't actually trip over it. It made it look as if the coder didn't understand what the

Re: [PATCH v10 9/9] convert: add round trip check based on 'core.checkRoundtripEncoding'

> On 07 Mar 2018, at 20:59, Junio C Hamano wrote: > > lars.schnei...@autodesk.com writes: > >> +static int check_roundtrip(const char* enc_name) > > The asterisk sticks to the variable, not type. Argh. I need to put this check into Travis CI ;-) >> +{ >> +/* >> +

Re: [PATCH v10 9/9] convert: add round trip check based on 'core.checkRoundtripEncoding'

lars.schnei...@autodesk.com writes: > +static int check_roundtrip(const char* enc_name) The asterisk sticks to the variable, not type. > +{ > + /* > + * check_roundtrip_encoding contains a string of space and/or > + * comma separated encodings (eg. "UTF-16, ASCII, CP1125"). > +

[PATCH v10 9/9] convert: add round trip check based on 'core.checkRoundtripEncoding'

From: Lars Schneider UTF supports lossless conversion round tripping and conversions between UTF and other encodings are mostly round trip safe as Unicode aims to be a superset of all other character encodings. However, certain encodings (e.g. SHIFT-JIS) are known to