Re: [PATCH v11 05/13] ref-filter: implement an `align` atom

2015-08-17 Thread Karthik Nayak
On Mon, Aug 17, 2015 at 11:52 PM, Eric Sunshine wrote: > On Mon, Aug 17, 2015 at 10:28 AM, Karthik Nayak wrote: >> On Mon, Aug 17, 2015 at 7:37 AM, Eric Sunshine >> wrote: >>> On Sat, Aug 15, 2015 at 2:00 PM, Karthik Nayak >>> wrote: +{ + struct strbuf aligned = STRBUF_INIT; >

Re: [PATCH v11 05/13] ref-filter: implement an `align` atom

2015-08-17 Thread Junio C Hamano
Karthik Nayak writes: > On Mon, Aug 17, 2015 at 7:37 AM, Eric Sunshine > wrote: > ... >> Second, I realize that Junio suggested the 'return_to' idea, but it >> seems like it could become overly painful since each handler of this >> sort is going to have to perform the same manipulation to appen

Re: [PATCH v11 05/13] ref-filter: implement an `align` atom

2015-08-17 Thread Eric Sunshine
On Mon, Aug 17, 2015 at 10:28 AM, Karthik Nayak wrote: > On Mon, Aug 17, 2015 at 7:37 AM, Eric Sunshine > wrote: >> On Sat, Aug 15, 2015 at 2:00 PM, Karthik Nayak wrote: >>> +{ >>> + struct strbuf aligned = STRBUF_INIT; >>> + struct ref_formatting_state *return_to = state->prev; >>>

Re: [PATCH v11 05/13] ref-filter: implement an `align` atom

2015-08-17 Thread Karthik Nayak
On Mon, Aug 17, 2015 at 7:37 AM, Eric Sunshine wrote: > On Sat, Aug 15, 2015 at 2:00 PM, Karthik Nayak wrote: >> Implement an `align` atom which left-, middle-, or right-aligns the >> content between %(align:..) and %(end). >> >> It is followed by `:,`, where the `` is >> either left, right or mi

Re: [PATCH v11 05/13] ref-filter: implement an `align` atom

2015-08-16 Thread Eric Sunshine
On Sat, Aug 15, 2015 at 2:00 PM, Karthik Nayak wrote: > Implement an `align` atom which left-, middle-, or right-aligns the > content between %(align:..) and %(end). > > It is followed by `:,`, where the `` is > either left, right or middle and `` is the size of the area > into which the content w

Re: [PATCH v11 05/13] ref-filter: implement an `align` atom

2015-08-16 Thread Eric Sunshine
On Sun, Aug 16, 2015 at 8:04 AM, Andreas Schwab wrote: > Karthik Nayak writes: >> I think we need to squash this in >> >> diff --git a/Documentation/git-for-each-ref.txt >> b/Documentation/git-for-each-ref.txt >> index 3099631..17bd15e 100644 >> --- a/Documentation/git-for-each-ref.txt >> +++ b/D

Re: [PATCH v11 05/13] ref-filter: implement an `align` atom

2015-08-16 Thread Andreas Schwab
Karthik Nayak writes: > I think we need to squash this in > > diff --git a/Documentation/git-for-each-ref.txt > b/Documentation/git-for-each-ref.txt > index 3099631..17bd15e 100644 > --- a/Documentation/git-for-each-ref.txt > +++ b/Documentation/git-for-each-ref.txt > @@ -129,7 +129,7 @@ color::

Re: [PATCH v11 05/13] ref-filter: implement an `align` atom

2015-08-16 Thread Karthik Nayak
I think we need to squash this in diff --git a/Documentation/git-for-each-ref.txt b/Documentation/git-for-each-ref.txt index 3099631..17bd15e 100644 --- a/Documentation/git-for-each-ref.txt +++ b/Documentation/git-for-each-ref.txt @@ -129,7 +129,7 @@ color:: align:: left-, middle-, or ri

[PATCH v11 05/13] ref-filter: implement an `align` atom

2015-08-15 Thread Karthik Nayak
Implement an `align` atom which left-, middle-, or right-aligns the content between %(align:..) and %(end). It is followed by `:,`, where the `` is either left, right or middle and `` is the size of the area into which the content will be placed. If the content between %(align:) and %(end) is more