Re: [PATCH v11 08/41] refs.c: add an err argument to delete_ref_loose

2014-05-28 Thread Ronnie Sahlberg
On Tue, May 27, 2014 at 5:25 PM, Jonathan Nieder wrote: > Hi, > > Comments from http://marc.info/?l=git&m=140079653930751&w=2: > > Ronnie Sahlberg wrote: > > [...] >> --- a/refs.c >> +++ b/refs.c >> @@ -2491,17 +2491,43 @@ static int repack_without_ref(const char *refname) >> return repack_w

Re: [PATCH v11 08/41] refs.c: add an err argument to delete_ref_loose

2014-05-27 Thread Jonathan Nieder
Hi, Comments from http://marc.info/?l=git&m=140079653930751&w=2: Ronnie Sahlberg wrote: [...] > --- a/refs.c > +++ b/refs.c > @@ -2491,17 +2491,43 @@ static int repack_without_ref(const char *refname) > return repack_without_refs(&refname, 1, NULL); > } > > -static int delete_ref_loose(

[PATCH v11 08/41] refs.c: add an err argument to delete_ref_loose

2014-05-27 Thread Ronnie Sahlberg
Add an err argument to delete_loose_ref so that we can pass a descriptive error string back to the caller. Pass the err argument from transaction commit to this function so that transaction users will have a nice error string if the transaction failed due to delete_loose_ref. Add a new function un