Re: [PATCH v11 1/4] ref-filter: use "struct object_id" consistently

Thanks for your very thorough review Eric! I think I address all the points, but if I missed something please let me know. On Sun, Apr 8, 2018 at 3:06 AM, Eric Sunshine wrote: > > You incorrectly dropped Peff's sign-off[1] when re-sending the patches > he authored in

Re: [PATCH v11 1/4] ref-filter: use "struct object_id" consistently

On Sat, Apr 7, 2018 at 12:42 PM, Harald Nordgren wrote: > From: Jeff King > > Internally we store a "struct object_id", and all of our > callers have one to pass us. But we insist that they peel it > to its bare-sha1 hash, which we then hashcpy() into

[PATCH v11 1/4] ref-filter: use "struct object_id" consistently

From: Jeff King Internally we store a "struct object_id", and all of our callers have one to pass us. But we insist that they peel it to its bare-sha1 hash, which we then hashcpy() into place. Let's pass it around as an object_id, which future-proofs us for a post-sha1 world. ---