Re: [PATCH v11 13/41] refs.c: change ref_transaction_create to do error checking and return status

2014-05-28 Thread Jonathan Nieder
Ronnie Sahlberg wrote: > Can you re-review these patches for me : > > please review > > 67b8fce refs.c: add an err argument to repack_without_refs > 738ac43 refs.c: add an err argument to delete_ref_loose > b78b0e0 refs.c: update ref_transaction_delete to check for error and > return status > e558

Re: [PATCH v11 13/41] refs.c: change ref_transaction_create to do error checking and return status

2014-05-28 Thread Ronnie Sahlberg
Thanks Can you re-review these patches for me : please review 67b8fce refs.c: add an err argument to repack_without_refs 738ac43 refs.c: add an err argument to delete_ref_loose b78b0e0 refs.c: update ref_transaction_delete to check for error and return status e558f96 refs.c: add transaction.stat

Re: [PATCH v11 13/41] refs.c: change ref_transaction_create to do error checking and return status

2014-05-28 Thread Jonathan Nieder
Ronnie Sahlberg wrote: > Please re-review. 06df8942 is Reviewed-by: Jonathan Nieder Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v11 13/41] refs.c: change ref_transaction_create to do error checking and return status

2014-05-28 Thread Ronnie Sahlberg
On Wed, May 28, 2014 at 10:07 AM, Jonathan Nieder wrote: > Ronnie Sahlberg wrote: > >> Updated the comment in refs.h > > Thanks. > >> +++ b/refs.h >> @@ -215,6 +215,31 @@ enum action_on_err { >> }; >> >> /* >> + * On error, transaction functions append a message about what >> + * went wrong to t

Re: [PATCH v11 13/41] refs.c: change ref_transaction_create to do error checking and return status

2014-05-28 Thread Jonathan Nieder
Ronnie Sahlberg wrote: > Updated the comment in refs.h Thanks. > +++ b/refs.h > @@ -215,6 +215,31 @@ enum action_on_err { > }; > > /* > + * On error, transaction functions append a message about what > + * went wrong to the 'err' argument. The message mentions what > + * ref was being updat

Re: [PATCH v11 13/41] refs.c: change ref_transaction_create to do error checking and return status

2014-05-28 Thread Ronnie Sahlberg
On Tue, May 27, 2014 at 5:42 PM, Jonathan Nieder wrote: > Hi, > > Ronnie Sahlberg wrote: > >> --- a/refs.h >> +++ b/refs.h >> @@ -215,6 +215,15 @@ enum action_on_err { >> }; >> >> /* >> + * Transaction functions that take an err argument will append an error >> + * string to this buffer if there

Re: [PATCH v11 13/41] refs.c: change ref_transaction_create to do error checking and return status

2014-05-27 Thread Jonathan Nieder
Hi, Ronnie Sahlberg wrote: > --- a/refs.h > +++ b/refs.h > @@ -215,6 +215,15 @@ enum action_on_err { > }; > > /* > + * Transaction functions that take an err argument will append an error > + * string to this buffer if there was a failure. > + * This string is not cleared on each call and may

[PATCH v11 13/41] refs.c: change ref_transaction_create to do error checking and return status

2014-05-27 Thread Ronnie Sahlberg
Do basic error checking in ref_transaction_create() and make it return non-zero on error. Update all callers to check the result of ref_transaction_create(). There are currently no conditions in _create that will return error but there will be in the future. Add an err argument that will be updated