Re: [PATCH v11 29/41] refs.c: remove the update_ref_write function

2014-05-28 Thread Jonathan Nieder
Ronnie Sahlberg wrote: > Signed-off-by: Ronnie Sahlberg > --- > refs.c | 35 +-- > 1 file changed, 9 insertions(+), 26 deletions(-) Reviewed-by: Jonathan Nieder -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord.

[PATCH v11 29/41] refs.c: remove the update_ref_write function

2014-05-27 Thread Ronnie Sahlberg
Since we only call update_ref_write from a single place and we only call it with onerr==QUIET_ON_ERR we can just as well get rid of it and just call write_ref_sha1 directly. This changes the return status for _commit from 1 to -1 on failures when writing to the ref. Eventually we will want _commit