Re: [PATCH v12 04/10] utf8: teach same_encoding() alternative UTF encoding names

> On 16 Mar 2018, at 19:19, Eric Sunshine wrote: > > On Fri, Mar 16, 2018 at 1:50 PM, Junio C Hamano wrote: >> Eric Sunshine writes: >>> However, I'm having a tough time imagining cases in which callers >>> would want

Re: [PATCH v12 04/10] utf8: teach same_encoding() alternative UTF encoding names

On Fri, Mar 16, 2018 at 1:50 PM, Junio C Hamano wrote: > Eric Sunshine writes: >> However, I'm having a tough time imagining cases in which callers >> would want same_encoding() to return true if both arguments are NULL, >> but outright crash if only

Re: [PATCH v12 04/10] utf8: teach same_encoding() alternative UTF encoding names

Eric Sunshine writes: > However, I'm having a tough time imagining cases in which callers > would want same_encoding() to return true if both arguments are NULL, > but outright crash if only one is NULL (which is the behavior even > before this patch). In other words,

Re: [PATCH v12 04/10] utf8: teach same_encoding() alternative UTF encoding names

On Thu, Mar 15, 2018 at 7:35 PM, Lars Schneider wrote: >> On 16 Mar 2018, at 00:25, Eric Sunshine wrote: >>>if (is_encoding_utf8(src) && is_encoding_utf8(dst)) >>>return 1; >>> + if (same_utf_encoding(src, dst)) >>>

Re: [PATCH v12 04/10] utf8: teach same_encoding() alternative UTF encoding names

> On 16 Mar 2018, at 00:25, Eric Sunshine wrote: > > On Thu, Mar 15, 2018 at 6:57 PM, wrote: >> The function same_encoding() checked only for alternative UTF-8 encoding >> names. Teach it to check for all kinds of alternative UTF encoding

Re: [PATCH v12 04/10] utf8: teach same_encoding() alternative UTF encoding names

On Thu, Mar 15, 2018 at 6:57 PM, wrote: > The function same_encoding() checked only for alternative UTF-8 encoding > names. Teach it to check for all kinds of alternative UTF encoding > names. > > Signed-off-by: Lars Schneider > --- > diff

[PATCH v12 04/10] utf8: teach same_encoding() alternative UTF encoding names

From: Lars Schneider The function same_encoding() checked only for alternative UTF-8 encoding names. Teach it to check for all kinds of alternative UTF encoding names. This function is used in a subsequent commit. Signed-off-by: Lars Schneider