Re: [PATCH v13 02/12] ref-filter: introduce ref_formatting_state and ref_formatting_stack

2015-08-25 Thread Karthik Nayak
On Tue, Aug 25, 2015 at 3:26 AM, Junio C Hamano gits...@pobox.com wrote: Karthik Nayak karthik@gmail.com writes: +static void push_new_stack_element(struct ref_formatting_stack **stack) +{ Micronit. Perhaps s/_new//;, as you do not call the other function pop_old_stack_element(). The

Re: [PATCH v13 02/12] ref-filter: introduce ref_formatting_state and ref_formatting_stack

2015-08-24 Thread Junio C Hamano
Karthik Nayak karthik@gmail.com writes: +static void push_new_stack_element(struct ref_formatting_stack **stack) +{ Micronit. Perhaps s/_new//;, as you do not call the other function pop_old_stack_element(). The remainder of this step looks pretty straight-forward and was a pleasant

[PATCH v13 02/12] ref-filter: introduce ref_formatting_state and ref_formatting_stack

2015-08-21 Thread Karthik Nayak
Introduce ref_formatting_state which will hold the formatted output strbuf instead of directly printing to stdout. This will help us in creating modifier atoms which modify the format specified before printing to stdout. Implement a stack machinery for ref_formatting_state, this allows us to push