On Tue, May 3, 2016 at 9:47 PM, Eric Sunshine wrote:
> On Tue, May 3, 2016 at 5:18 AM, Pranit Bauva wrote:
>> On Tue, May 3, 2016 at 12:19 PM, Eric Sunshine
>> wrote:
> Step back a moment and recall why these tests were added. Earlier
> rounds of this series were buggy and caused regres
On Tue, May 3, 2016 at 5:18 AM, Pranit Bauva wrote:
> On Tue, May 3, 2016 at 12:19 PM, Eric Sunshine
> wrote:
Step back a moment and recall why these tests were added. Earlier
rounds of this series were buggy and caused regressions in git-status.
As a consequence, reviewers sugges
Eric Sunshine writes:
One previous commit (title: commit: add a commit.verbose config
variable) introduced a new config variable named commit.verbose,
so care should be taken that it would not affect the behavior of
status.
Another previous commit (title: "parse-opti
On Tue, May 3, 2016 at 12:19 PM, Eric Sunshine wrote:
> On Tue, May 3, 2016 at 2:42 AM, Pranit Bauva wrote:
>> On Tue, May 3, 2016 at 10:42 AM, Eric Sunshine
>> wrote:
>>> On Mon, May 2, 2016 at 11:39 PM, Pranit Bauva
>>> wrote:
I agree that using test_expect_failure would be a better wa
On Tue, May 3, 2016 at 2:42 AM, Pranit Bauva wrote:
> On Tue, May 3, 2016 at 10:42 AM, Eric Sunshine
> wrote:
>> On Mon, May 2, 2016 at 11:39 PM, Pranit Bauva wrote:
>>> I agree that using test_expect_failure would be a better way of going
>>> with this thing. Thanks. Will send an updated patch
On Tue, May 3, 2016 at 10:42 AM, Eric Sunshine wrote:
> On Mon, May 2, 2016 at 11:39 PM, Pranit Bauva wrote:
>> On Tue, May 3, 2016 at 4:37 AM, Junio C Hamano wrote:
>>> Pranit Bauva writes:
Variable named 'verbose' in builtin/commit.c is consumed by git-status
and git-commit so if a
On Mon, May 2, 2016 at 11:39 PM, Pranit Bauva wrote:
> On Tue, May 3, 2016 at 4:37 AM, Junio C Hamano wrote:
>> Pranit Bauva writes:
>>> Variable named 'verbose' in builtin/commit.c is consumed by git-status
>>> and git-commit so if a new verbose related behavior is introduced in
>>> git-commit,
On Tue, May 3, 2016 at 4:37 AM, Junio C Hamano wrote:
> Pranit Bauva writes:
>
>> Variable named 'verbose' in builtin/commit.c is consumed by git-status
>> and git-commit so if a new verbose related behavior is introduced in
>> git-commit, then it should not affect the behavior of git-status.
>>
Pranit Bauva writes:
> Variable named 'verbose' in builtin/commit.c is consumed by git-status
> and git-commit so if a new verbose related behavior is introduced in
> git-commit, then it should not affect the behavior of git-status.
>
> One previous commit (title: commit: add a commit.verbose con
Variable named 'verbose' in builtin/commit.c is consumed by git-status
and git-commit so if a new verbose related behavior is introduced in
git-commit, then it should not affect the behavior of git-status.
One previous commit (title: commit: add a commit.verbose config
variable) introduced a new c
10 matches
Mail list logo