Re: [PATCH v16 Part II 7/8] bisect--helper: `bisect_start` shell function partially in C

> diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c > index ab0580ce0089a..4ac175c49e80c 100644 > --- a/builtin/bisect--helper.c > +++ b/builtin/bisect--helper.c > + /* > + * Check if we are bisecting > + */ > + if

Re: [PATCH v16 Part II 7/8] bisect--helper: `bisect_start` shell function partially in C

Hey Stephan, On Mon, Oct 30, 2017 at 10:21 PM, Stephan Beyer wrote: > Hi, > >> + return error(_("unrecognised option: '%s'"), arg); > > Please write "unrecogni_z_ed". > > Since the string for translation changed from > "unrecognised option: '$arg'" >

Re: [PATCH v16 Part II 7/8] bisect--helper: `bisect_start` shell function partially in C

Hi, > + return error(_("unrecognised option: '%s'"), arg); Please write "unrecogni_z_ed". Since the string for translation changed from "unrecognised option: '$arg'" to "unrecognised option: '%s'" anyway, it does not result in further work for the translators

[PATCH v16 Part II 7/8] bisect--helper: `bisect_start` shell function partially in C

Reimplement the `bisect_start` shell function partially in C and add `bisect-start` subcommand to `git bisect--helper` to call it from git-bisect.sh . The last part is not converted because it calls another shell function `bisect_start` shell function will be completed after the `bisect_next`