Re: [PATCH v2] Allow use of TLS 1.3

2018-03-24 Thread Loganaden Velvindron
On Sat, Mar 24, 2018 at 2:04 AM, Junio C Hamano wrote: > Daniel Stenberg writes: > >> On Fri, 23 Mar 2018, Loganaden Velvindron wrote: >> >>> +#ifdef CURL_SSLVERSION_TLSv1_3 >>> +{ "tlsv1.3", CURL_SSLVERSION_TLSv1_3 } >>> +#endif >> >> Unfortunately,

Re: [PATCH v2] Allow use of TLS 1.3

2018-03-23 Thread Loganaden Velvindron
On Sat, Mar 24, 2018 at 1:47 AM, Daniel Stenberg wrote: > On Fri, 23 Mar 2018, Loganaden Velvindron wrote: > >> +#ifdef CURL_SSLVERSION_TLSv1_3 >> + { "tlsv1.3", CURL_SSLVERSION_TLSv1_3 } >> +#endif > > > Unfortunately, CURL_SSLVERSION_TLSv1_3 is an enum so this construct

Re: [PATCH v2] Allow use of TLS 1.3

2018-03-23 Thread Loganaden Velvindron
On Sat, Mar 24, 2018 at 1:47 AM, Daniel Stenberg wrote: > On Fri, 23 Mar 2018, Loganaden Velvindron wrote: > >> +#ifdef CURL_SSLVERSION_TLSv1_3 >> + { "tlsv1.3", CURL_SSLVERSION_TLSv1_3 } >> +#endif > > > Unfortunately, CURL_SSLVERSION_TLSv1_3 is an enum so this construct

Re: [PATCH v2] Allow use of TLS 1.3

2018-03-23 Thread Loganaden Velvindron
On Sat, Mar 24, 2018 at 1:55 AM, Junio C Hamano <gits...@pobox.com> wrote: > Loganaden Velvindron <lo...@hackers.mu> writes: > >> Subject: Re: [PATCH v2] Allow use of TLS 1.3 > > Let's retitle it to something like > > Subject: [PATCH v2] http: allow use

Re: [PATCH v2] Allow use of TLS 1.3

2018-03-23 Thread Loganaden Velvindron
On Sat, Mar 24, 2018 at 1:47 AM, Daniel Stenberg wrote: > On Fri, 23 Mar 2018, Loganaden Velvindron wrote: > >> +#ifdef CURL_SSLVERSION_TLSv1_3 >> + { "tlsv1.3", CURL_SSLVERSION_TLSv1_3 } >> +#endif > > > Unfortunately, CURL_SSLVERSION_TLSv1_3 is an enum so this construct

Re: [PATCH v2] Allow use of TLS 1.3

2018-03-23 Thread Ævar Arnfjörð Bjarmason
On Fri, Mar 23 2018, Junio C. Hamano wrote: >> @@ -62,6 +62,9 @@ static struct { >> { "tlsv1.1", CURL_SSLVERSION_TLSv1_1 }, >> { "tlsv1.2", CURL_SSLVERSION_TLSv1_2 }, >> #endif >> +#ifdef CURL_SSLVERSION_TLSv1_3 >> +{ "tlsv1.3", CURL_SSLVERSION_TLSv1_3 } >> +#endif >> }; > > It

Re: [PATCH v2] Allow use of TLS 1.3

2018-03-23 Thread Junio C Hamano
Daniel Stenberg writes: > On Fri, 23 Mar 2018, Loganaden Velvindron wrote: > >> +#ifdef CURL_SSLVERSION_TLSv1_3 >> +{ "tlsv1.3", CURL_SSLVERSION_TLSv1_3 } >> +#endif > > Unfortunately, CURL_SSLVERSION_TLSv1_3 is an enum so this construct > won't work. > > Also, let me just

Re: [PATCH v2] Allow use of TLS 1.3

2018-03-23 Thread Junio C Hamano
Loganaden Velvindron <lo...@hackers.mu> writes: > Subject: Re: [PATCH v2] Allow use of TLS 1.3 Let's retitle it to something like Subject: [PATCH v2] http: allow use of TLS 1.3 > Add a tlsv1.3 option to http.sslVersion in addition to the existing > tlsv1.[012] optio

Re: [PATCH v2] Allow use of TLS 1.3

2018-03-23 Thread Daniel Stenberg
On Fri, 23 Mar 2018, Loganaden Velvindron wrote: +#ifdef CURL_SSLVERSION_TLSv1_3 + { "tlsv1.3", CURL_SSLVERSION_TLSv1_3 } +#endif Unfortunately, CURL_SSLVERSION_TLSv1_3 is an enum so this construct won't work. Also, let me just point out that 7.52.0 is 0x073400 in hex and not the one

[PATCH v2] Allow use of TLS 1.3

2018-03-23 Thread Loganaden Velvindron
Add a tlsv1.3 option to http.sslVersion in addition to the existing tlsv1.[012] options. libcurl has supported this since 7.52.0. Done during IETF 101 Hackathon Signed-off-by: Loganaden Velvindron --- Documentation/config.txt | 2 +- http.c | 3 +++ 2 files