Re: [PATCH v2] Rename suffixcmp() to has_suffix() and inverse its result

2013-11-05 Thread Junio C Hamano
Max Horn m...@quendi.de writes: +1 for the change. I find the resulting code easier to understand, too. ... Taking one step back, shouldn't the commit message rather explain the new status, instead of referring so much to the past? If I imagine somebody reading this in a year, they might

[PATCH v2] Rename suffixcmp() to has_suffix() and inverse its result

2013-11-04 Thread Christian Couder
As suffixcmp() should not be used as an ordering comparison function, and anything-cmp() ought to be usable as an ordering comparison function, suffixcmp() should be renamed to something that doesn't end with cmp. has_suffix() is a straightforward name for such a function, except that with such a