Re: [PATCH v2] allow TTY tests to run under recent Mac OS

2014-11-14 Thread John Szakmeister
On Thu, Nov 13, 2014 at 5:40 PM, Mike Blume blume.m...@gmail.com wrote: listed bug doesn't reproduce on Mac OS Yosemite. For now, just enable TTY on Yosemite and higher I've tried the reproduction recipe on Mavericks (`uname -r` = 13.4.0) and it works fine--still going after 12,000 iterations.

Re: [PATCH v2] allow TTY tests to run under recent Mac OS

2014-11-14 Thread Johannes Sixt
Am 13.11.2014 um 23:40 schrieb Mike Blume: listed bug doesn't reproduce on Mac OS Yosemite. For now, just enable TTY on Yosemite and higher Signed-off-by: Mike Blume blume.m...@gmail.com Improved-by: Junio C Hamano gits...@pobox.com --- t/lib-terminal.sh | 5 - 1 file changed, 4

Re: [PATCH v2] allow TTY tests to run under recent Mac OS

2014-11-14 Thread Michael Blume
My understanding is that and || have equal precedence, and this seems to be borne out in testing at my shell. If the if/then method is clearer I'm happy to go with that. On Fri, Nov 14, 2014 at 11:23 AM, Johannes Sixt j...@kdbg.org wrote: Am 13.11.2014 um 23:40 schrieb Mike Blume: listed bug

Re: [PATCH v2] allow TTY tests to run under recent Mac OS

2014-11-14 Thread Jeff King
On Fri, Nov 14, 2014 at 11:48:36AM -0800, Michael Blume wrote: My understanding is that and || have equal precedence, and this seems to be borne out in testing at my shell. If the if/then method is clearer I'm happy to go with that. I think the problem is that there are earlier parts of the

Re: [PATCH v2] allow TTY tests to run under recent Mac OS

2014-11-14 Thread Michael Blume
Right, I missed that there was more going on above, thanks =) On Fri, Nov 14, 2014 at 12:02 PM, Jeff King p...@peff.net wrote: On Fri, Nov 14, 2014 at 11:48:36AM -0800, Michael Blume wrote: My understanding is that and || have equal precedence, and this seems to be borne out in testing at my

Re: [PATCH v2] allow TTY tests to run under recent Mac OS

2014-11-14 Thread Junio C Hamano
Jeff King p...@peff.net writes: On Fri, Nov 14, 2014 at 11:48:36AM -0800, Michael Blume wrote: My understanding is that and || have equal precedence, and this seems to be borne out in testing at my shell. If the if/then method is clearer I'm happy to go with that. I think the problem is

[PATCH v2] allow TTY tests to run under recent Mac OS

2014-11-13 Thread Mike Blume
listed bug doesn't reproduce on Mac OS Yosemite. For now, just enable TTY on Yosemite and higher Signed-off-by: Mike Blume blume.m...@gmail.com Improved-by: Junio C Hamano gits...@pobox.com --- t/lib-terminal.sh | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git