Re: [PATCH v2] archive-tar: fix a sparse 'constant too large' warning

Hi Junio, On Wed, 10 May 2017, Junio C Hamano wrote: > Ramsay Jones writes: > > > Yeah, I had a similar comment in the commit message (but much more > > verbose than your concise addition above), but I edited it several > > times, without finding a wording that I

Re: [PATCH v2] archive-tar: fix a sparse 'constant too large' warning

Ramsay Jones writes: > Yeah, I had a similar comment in the commit message (but much more > verbose than your concise addition above), but I edited it several > times, without finding a wording that I liked. I eventually removed > it, because it didn't really add any

Re: [PATCH v2] archive-tar: fix a sparse 'constant too large' warning

Ramsay Jones writes: > In a similar vein, on systems which use a 64-bit representation of the > 'unsigned long' type, the USTAR_MAX_SIZE constant macro is defined with > the value 0777ULL. Although this does not cause any warning > messages to be issued, it

Re: [PATCH v2] archive-tar: fix a sparse 'constant too large' warning

On 09/05/17 11:24, Johannes Schindelin wrote: > Hi Ramsay, > > On Mon, 8 May 2017, Ramsay Jones wrote: > >> Commit dddbad728c ("timestamp_t: a new data type for timestamps", >> 26-04-2017) introduced a new typedef 'timestamp_t', as a synonym for an >> unsigned long, which was used at the time

Re: [PATCH v2] archive-tar: fix a sparse 'constant too large' warning

Hi Ramsay, On Mon, 8 May 2017, Ramsay Jones wrote: > Commit dddbad728c ("timestamp_t: a new data type for timestamps", > 26-04-2017) introduced a new typedef 'timestamp_t', as a synonym for an > unsigned long, which was used at the time to represent timestamps in > git. A later commit 28f4aee3fb

[PATCH v2] archive-tar: fix a sparse 'constant too large' warning

Commit dddbad728c ("timestamp_t: a new data type for timestamps", 26-04-2017) introduced a new typedef 'timestamp_t', as a synonym for an unsigned long, which was used at the time to represent timestamps in git. A later commit 28f4aee3fb ("use uintmax_t for timestamps", 26-04-2017) changed the