Re: [PATCH v2] builtin/remote: quote remote name on error to display empty name

2018-09-14 Thread Junio C Hamano
Shulhan writes: > if source is run successfully before I know the patch was correct, as > the "t/README" said, > > Running Tests > - > > The easiest way to run tests is to say "make". This runs all > the tests. t/README says that it is sufficient to run "make" to perform

Re: [PATCH v2] builtin/remote: quote remote name on error to display empty name

2018-09-14 Thread Shulhan
On Thu, 13 Sep 2018 14:51:56 -0700 Junio C Hamano wrote: > Shulhan writes: > > > When adding new remote name with empty string, git will print the > > following error message, > > > > fatal: '' is not a valid remote name\n > > > > But when removing remote name with empty string as input, git

Re: [PATCH v2] builtin/remote: quote remote name on error to display empty name

2018-09-13 Thread Junio C Hamano
Junio C Hamano writes: > Have you run "make test" with this change? > > I expect at least 5505.10 to fail without adjustment. For now, I'll queue this on top, and if this turns out to be sufficient, I will squash it in. t/t5505-remote.sh | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [PATCH v2] builtin/remote: quote remote name on error to display empty name

2018-09-13 Thread Junio C Hamano
Shulhan writes: > When adding new remote name with empty string, git will print the > following error message, > > fatal: '' is not a valid remote name\n > > But when removing remote name with empty string as input, git shows the > empty string without quote, > > fatal: No such remote: \n >

[PATCH v2] builtin/remote: quote remote name on error to display empty name

2018-09-13 Thread Shulhan
When adding new remote name with empty string, git will print the following error message, fatal: '' is not a valid remote name\n But when removing remote name with empty string as input, git shows the empty string without quote, fatal: No such remote: \n To make these error messages