Re: [PATCH v2] cache.h: eliminate SHA-1 deprecation warnings on OS X 10.8

2013-05-11 Thread Jeff King
On Sat, May 11, 2013 at 02:17:10AM -0700, David Aguilar wrote: > Good catch. I had a config.mak without any -O flags in CFLAGS. > Here are the timings with -O3. We're back to parity. > > $ time git rev-list --all --objects --verify-objects >/dev/null > > # CommonCrypto 28.95s user 4.62s system

Re: [PATCH v2] cache.h: eliminate SHA-1 deprecation warnings on OS X 10.8

2013-05-11 Thread David Aguilar
On Sat, May 11, 2013 at 1:45 AM, Jeff King wrote: > On Sat, May 11, 2013 at 01:38:32AM -0700, David Aguilar wrote: > >> > Adding "--verify-objects" would sha1 the blobs, too, which might be more >> > reasonable (or running "git fsck"). Something like "git add" on a large >> > blob would also be a

Re: [PATCH v2] cache.h: eliminate SHA-1 deprecation warnings on OS X 10.8

2013-05-11 Thread Jeff King
On Sat, May 11, 2013 at 01:38:32AM -0700, David Aguilar wrote: > > Adding "--verify-objects" would sha1 the blobs, too, which might be more > > reasonable (or running "git fsck"). Something like "git add" on a large > > blob would also be a good test. > > Thanks. Here are the numbers with --veri

Re: [PATCH v2] cache.h: eliminate SHA-1 deprecation warnings on OS X 10.8

2013-05-11 Thread David Aguilar
On Sat, May 11, 2013 at 1:22 AM, Jeff King wrote: > On Sat, May 11, 2013 at 12:11:05AM -0700, David Aguilar wrote: > >> > Does this perform better or worse than just setting >> > BLK_SHA1=YesPlease? I'd naively think it could go either way: on one >> > hand adding another library dependency can s

Re: [PATCH v2] cache.h: eliminate SHA-1 deprecation warnings on OS X 10.8

2013-05-11 Thread Jeff King
On Sat, May 11, 2013 at 12:11:05AM -0700, David Aguilar wrote: > > Does this perform better or worse than just setting > > BLK_SHA1=YesPlease? I'd naively think it could go either way: on one > > hand adding another library dependency can slow down startup, and on > > the other hand the implement

Re: [PATCH v2] cache.h: eliminate SHA-1 deprecation warnings on OS X 10.8

2013-05-11 Thread David Aguilar
On Fri, May 10, 2013 at 11:23 PM, Jonathan Nieder wrote: > Hi, > > David Aguilar wrote: > >> Mac OS X Mountain Lion prints warnings when building git: >> >> warning: 'SHA1_Init' is deprecated >> (declared at /usr/include/openssl/sha.h:121) >> >> Silence the warnings by using the Common

Re: [PATCH v2] cache.h: eliminate SHA-1 deprecation warnings on OS X 10.8

2013-05-10 Thread Jonathan Nieder
Hi, David Aguilar wrote: > Mac OS X Mountain Lion prints warnings when building git: > > warning: 'SHA1_Init' is deprecated > (declared at /usr/include/openssl/sha.h:121) > > Silence the warnings by using the Common Digest SHA-1 > functions for SHA1_Init(), SHA1_Update(), and SHA1_Fin

[PATCH v2] cache.h: eliminate SHA-1 deprecation warnings on OS X 10.8

2013-05-10 Thread David Aguilar
Mac OS X Mountain Lion prints warnings when building git: warning: 'SHA1_Init' is deprecated (declared at /usr/include/openssl/sha.h:121) Silence the warnings by using the Common Digest SHA-1 functions for SHA1_Init(), SHA1_Update(), and SHA1_Final(). Add a COMMON_DIGEST_SHA1 kno