[PATCH v2] commit: add commit.signoff config option

2015-06-25 Thread Caio Marcelo de Oliveira Filho
In projects that use Signed-off-by, it's convenient to include that line in the commit message by default. The commit.signoff config option allows to add that line in all commits automatically. Document that this config option can be overriden by using --no-signoff. Signed-off-by: Caio Marcelo

Re: [PATCH v2] commit: add commit.signoff config option

2015-06-25 Thread Johannes Löthberg
On 25/06, Junio C Hamano wrote: Caio Marcelo de Oliveira Filho cmarc...@gmail.com writes: Hmm, I do not recall seeing v1 but that is OK. The following immediately comes to mind. http://thread.gmane.org/gmane.comp.version-control.git/51754/focus=51780 To be honest I'm not sure I buy that

Re: [PATCH v2] commit: add commit.signoff config option

2015-06-25 Thread Caio Marcelo de Oliveira Filho
Hi, Hmm, I do not recall seeing v1 but that is OK. http://thread.gmane.org/gmane.comp.version-control.git/272635 http://thread.gmane.org/gmane.comp.version-control.git/272636 The following immediately comes to mind. http://thread.gmane.org/gmane.comp.version-control.git/51754/focus=51780

Re: [PATCH v2] commit: add commit.signoff config option

2015-06-25 Thread Junio C Hamano
Caio Marcelo de Oliveira Filho cmarc...@gmail.com writes: In projects that use Signed-off-by, it's convenient to include that line in the commit message by default. The commit.signoff config option Hmm, I do not recall seeing v1 but that is OK. The following immediately comes to mind.

Re: [PATCH v2] commit: add commit.signoff config option

2015-06-25 Thread Junio C Hamano
Caio Marcelo de Oliveira Filho cmarc...@gmail.com writes: A similar concern probably applies to format.signOff option. Would be sufficient to add a note about conscious act (like format.signOff has) to the config description? I am generally in negative on automating this. This is not just

Re: [PATCH v2] commit: add commit.signoff config option

2015-06-25 Thread Torsten Bögershausen
On 2015-06-25 16.50, Caio Marcelo de Oliveira Filho wrote: +test_expect_success 'commit.signoff config option' ' + test_config commit.signoff true + echo yet another content *narf* foo Minor nit: The or should be written without a space, like this: foo -- To unsubscribe from

Re: [PATCH v2] commit: add commit.signoff config option

2015-06-25 Thread Matthieu Moy
Junio C Hamano gits...@pobox.com writes: [commit] signoff = I certify that all my work is licenseable under DCO I like this one. The paranoid version would be signoff = I certify that all my work in /home/my/projects/foo are ... to avoid mistakenly have the config option applied to