Re: [PATCH v2] commit: don't use-editor when allow-empty-message

2013-05-27 Thread Ramkumar Ramachandra
Antoine Pelisse wrote: > So now we have two fixes for the same issue, don't we ? > You probably missed $gmane/225534. Gah, missed that. Sorry for the noise. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH v2] commit: don't use-editor when allow-empty-message

2013-05-27 Thread Antoine Pelisse
So now we have two fixes for the same issue, don't we ? You probably missed $gmane/225534. On Mon, May 27, 2013 at 4:20 PM, Ramkumar Ramachandra wrote: > Commit a24a41e (git-commit: only append a newline to -m mesg if > necessary, 2013-02-18) introduced a regression: when > --allow-empty-message

[PATCH v2] commit: don't use-editor when allow-empty-message

2013-05-27 Thread Ramkumar Ramachandra
Commit a24a41e (git-commit: only append a newline to -m mesg if necessary, 2013-02-18) introduced a regression: when --allow-empty-message is used and an empty message is explicitly specified with -m "", git commit still launches $EDITOR unnecessarily. The commit (correctly) fixes opt_parse_m() to