This patch offloads completion functionality for format-patch to
__gitcomp_builtin. In addition to this, send-email was borrowing some
completion options from format-patch so those options are moved into
send-email's completions.
Signed-off-by: Denton Liu
---
I ran t9902-completion.sh on this pa
Denton Liu writes:
> This patch offloads completion functionality for format-patch to
> __gitcomp_builtin. In addition to this, send-email was borrowing some
> completion options from format-patch so those options are moved into
> send-email's completions.
>
> Signed-off-by: Denton Liu
> ---
>
>
On Tue, Oct 30, 2018 at 7:39 AM Denton Liu wrote:
>
> This patch offloads completion functionality for format-patch to
> __gitcomp_builtin. In addition to this, send-email was borrowing some
> completion options from format-patch so those options are moved into
> send-email's completions.
>
> Sign
Duy Nguyen writes:
>> -__git_format_patch_options="
>> - --stdout --attach --no-attach --thread --thread= --no-thread
>> - --numbered --start-number --numbered-files --keep-subject --signoff
>> - --signature --no-signature --in-reply-to= --cc= --full-index --binary
>> - --
On Thu, Nov 1, 2018 at 2:42 AM Junio C Hamano wrote:
> >> @@ -2080,16 +2071,19 @@ _git_send_email ()
> >> return
> >> ;;
> >> --*)
> >> - __gitcomp "--annotate --bcc --cc --cc-cmd --chain-reply-to
> >> - --compose --confir
Duy Nguyen writes:
>> > I have no comment about this. In an ideal world, sendemail.perl could
>> > be taught to support --git-completion-helper but I don't think my
>> > little remaining Perl knowledge (or time) is enough to do it. Perhaps
>> > this will do. I don't know.
>>
>> So "all", "attach"
On Fri, Nov 02, 2018 at 08:52:30AM +0900, Junio C Hamano wrote:
> Duy Nguyen writes:
>
> >> > I have no comment about this. In an ideal world, sendemail.perl could
> >> > be taught to support --git-completion-helper but I don't think my
> >> > little remaining Perl knowledge (or time) is enough t
On Sat, Nov 03, 2018 at 07:03:18AM +0100, Duy Nguyen wrote:
> Subject: [PATCH] completion: use __gitcomp_builtin for format-patch
>
> This helps format-patch gain completion for a couple new options,
> notably --range-diff.
>
> Since send-email completion relies on $__git_format_patch_options
> w
On Sat, Nov 3, 2018 at 8:59 AM Denton Liu wrote:
> > @@ -2081,7 +2077,7 @@ _git_send_email ()
> > return
> > ;;
> > --*)
> > - __gitcomp "--annotate --bcc --cc --cc-cmd --chain-reply-to
> > + __gitcomp_builtin send-email "--annotate --bcc -
Duy Nguyen writes:
>> Would it make sense to make send-email's completion helper print these
>> out directly? That way, if someone were to modify send-email in the
>> future, they'd only have to look through one file instead of both
>> send-email and the completions script.
>
> I did think about
10 matches
Mail list logo
