Re: [PATCH v2] convert: add "status=delayed" to filter process protocol

2017-04-09 Thread Lars Schneider
> On 27 Feb 2017, at 23:11, Jakub Narębski wrote: > > W dniu 27.02.2017 o 11:32, Lars Schneider pisze: >> >>> On 27 Feb 2017, at 10:58, Jeff King wrote: >>> >>> On Sun, Feb 26, 2017 at 07:48:16PM +0100, Lars Schneider wrote: >>> +If the request cannot be fulfilled within a reasonable am

Re: [PATCH v2] convert: add "status=delayed" to filter process protocol

2017-04-09 Thread Lars Schneider
> On 27 Feb 2017, at 11:53, Jeff King wrote: > > On Mon, Feb 27, 2017 at 11:32:47AM +0100, Lars Schneider wrote: > >> ... > >>> From Git's side, the loop is something like: >>> >>> while (delayed_items > 0) { >>> /* issue a wait, and get back the status/index pair */ >>> status = send

Re: [PATCH v2] convert: add "status=delayed" to filter process protocol

2017-02-27 Thread Jakub Narębski
W dniu 27.02.2017 o 11:32, Lars Schneider pisze: > >> On 27 Feb 2017, at 10:58, Jeff King wrote: >> >> On Sun, Feb 26, 2017 at 07:48:16PM +0100, Lars Schneider wrote: >> >>> +If the request cannot be fulfilled within a reasonable amount of time >>> +then the filter can respond with a "delayed" st

Re: [PATCH v2] convert: add "status=delayed" to filter process protocol

2017-02-27 Thread Jeff King
On Mon, Feb 27, 2017 at 11:32:47AM +0100, Lars Schneider wrote: > I completely agree - I need to change that. However, the goal of the v2 > iteration was to get the "convert" interface in an acceptable state. > That's what I intended to say in the patch comment section: > > "Please ignore all

Re: [PATCH v2] convert: add "status=delayed" to filter process protocol

2017-02-27 Thread Lars Schneider
> On 27 Feb 2017, at 10:58, Jeff King wrote: > > On Sun, Feb 26, 2017 at 07:48:16PM +0100, Lars Schneider wrote: > >> +If the request cannot be fulfilled within a reasonable amount of time >> +then the filter can respond with a "delayed" status and a flush packet. >> +Git will perform the same

Re: [PATCH v2] convert: add "status=delayed" to filter process protocol

2017-02-27 Thread Jeff King
On Sun, Feb 26, 2017 at 07:48:16PM +0100, Lars Schneider wrote: > +If the request cannot be fulfilled within a reasonable amount of time > +then the filter can respond with a "delayed" status and a flush packet. > +Git will perform the same request at a later point in time, again. The > +filter ca

[PATCH v2] convert: add "status=delayed" to filter process protocol

2017-02-26 Thread Lars Schneider
Some `clean` / `smudge` filters might require a significant amount of time to process a single blob. During this process the Git checkout operation is blocked and Git needs to wait until the filter is done to continue with the checkout. Teach the filter process protocol (introduced in edcc858) to