The "git diff --no-index" codepath didn't handle the --no-abbrev option.
Also it didn't behave the same as find_unique_abbrev()
in the case where abbrev == 0.
find_unique_abbrev() returns the full, unabbreviated string in that
case, but the "git diff --no-index" codepath returned an empty string.
On Fri, Dec 02, 2016 at 11:48:40AM -0700, Jack Bates wrote:
> The "git diff --no-index" codepath didn't handle the --no-abbrev option.
> Also it didn't behave the same as find_unique_abbrev()
> in the case where abbrev == 0.
> find_unique_abbrev() returns the full, unabbreviated string in that
> c
On Mon, Dec 05, 2016 at 01:01:16AM -0500, Jeff King wrote:
> Note that setting abbrev to "0" outside of a repository was broken
> recently by 4f03666ac (diff: handle sha1 abbreviations outside of
> repository, 2016-10-20). It adds a special out-of-repo code path for
> handling abbreviation
On Mon, Dec 05, 2016 at 01:15:00AM -0500, Jeff King wrote:
> On Mon, Dec 05, 2016 at 01:01:16AM -0500, Jeff King wrote:
>
> > Note that setting abbrev to "0" outside of a repository was broken
> > recently by 4f03666ac (diff: handle sha1 abbreviations outside of
> > repository, 2016-10-20).
4 matches
Mail list logo
